runtime/lib/byte_array.cc - Issue 12017020: Some more ^= to |=

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/byte_array.cc

Issue 12017020: Some more ^= to |= (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/byte_array.cc

===================================================================

--- runtime/lib/byte_array.cc (revision 17293)

+++ runtime/lib/byte_array.cc (working copy)

@@ -119,7 +119,7 @@

#define INTEGER_TO_UINT64(integer, uint64) \

if (integer.IsBigint()) { \

Bigint& bigint = Bigint::Handle(); \

- bigint ^= integer.raw(); \

+ bigint |= integer.raw(); \

hausner 2013/01/18 19:04:48 Why not Bigint& bigint = Bigint::Handle(integer.ra

srdjan 2013/01/18 20:02:47 Because 'integer.raw' is not of static type RawBig

ASSERT(BigintOperations::FitsIntoUint64(bigint)); \

value = BigintOperations::AbsToUint64(bigint); \

} else { \

« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')