Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: runtime/lib/integers.cc

Issue 12017020: Some more ^= to |= (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/integers.cc
===================================================================
--- runtime/lib/integers.cc (revision 17293)
+++ runtime/lib/integers.cc (working copy)
@@ -23,13 +23,13 @@
static bool CheckInteger(const Integer& i) {
if (i.IsBigint()) {
Bigint& bigint = Bigint::Handle();
hausner 2013/01/18 19:04:48 Why not Bigint& bigint = Bigint::Handle(i.raw);
srdjan 2013/01/18 20:02:47 Ditto.
- bigint ^= i.raw();
+ bigint |= i.raw();
return !BigintOperations::FitsIntoSmi(bigint) &&
!BigintOperations::FitsIntoMint(bigint);
}
if (i.IsMint()) {
Mint& mint = Mint::Handle();
- mint ^= i.raw();
+ mint |= i.raw();
hausner 2013/01/18 19:04:48 ditto
srdjan 2013/01/18 20:02:47 Ditto.
return !Smi::IsValid64(mint.value());
}
return true;
@@ -218,7 +218,7 @@
}
if (value.IsSmi()) {
Smi& smi_value = Smi::Handle();
hausner 2013/01/18 19:04:48 ditto
- smi_value ^= value.raw();
+ smi_value |= value.raw();
return smi_value.ShiftOp(kind, amount);
}
Bigint& big_value = Bigint::Handle();
@@ -240,7 +240,7 @@
}
} else {
ASSERT(value.IsBigint());
- big_value ^= value.raw();
+ big_value |= value.raw();
}
switch (kind) {
case Token::kSHL:

Powered by Google App Engine
This is Rietveld 408576698