Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 1201273004: Revert of Fix receiver when calling eval() bound by with scope (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix receiver when calling eval() bound by with scope (patchset #3 id:40001 of https://codereview.chromium.org/1202963005/) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream blink first. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/574 Please consider extra blink trybots on a reland. Original issue's description: > Fix receiver when calling eval() bound by with scope > > Thanks to André Bargull for the report. > > BUG=v8:4214 > LOG=N > R=arv@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/3c5f0db3a1768ade68108bf003676ce378d1cbdc > Cr-Commit-Position: refs/heads/master@{#29259} TBR=arv@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4214 Committed: https://crrev.com/93d130ce70c951022e80bb08f9e07da7b2fba0aa Cr-Commit-Position: refs/heads/master@{#29267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -538 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +62 lines, -71 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +66 lines, -75 lines 0 comments Download
M src/ast.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M src/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +59 lines, -67 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +60 lines, -69 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +60 lines, -69 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 4 chunks +42 lines, -48 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +37 lines, -47 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +59 lines, -67 lines 0 comments Download
D test/mjsunit/regress/regress-4214.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Fix receiver when calling eval() bound by with scope
5 years, 6 months ago (2015-06-24 19:08:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201273004/1
5 years, 6 months ago (2015-06-24 19:08:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 19:08:35 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 19:08:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93d130ce70c951022e80bb08f9e07da7b2fba0aa
Cr-Commit-Position: refs/heads/master@{#29267}

Powered by Google App Engine
This is Rietveld 408576698