Index: src/mips64/full-codegen-mips64.cc |
diff --git a/src/mips64/full-codegen-mips64.cc b/src/mips64/full-codegen-mips64.cc |
index 8979bac9f63d091a5c6e87c08628713a54d953d7..0453850fa7a283effd3c2655e398e46fe7df8ae5 100644 |
--- a/src/mips64/full-codegen-mips64.cc |
+++ b/src/mips64/full-codegen-mips64.cc |
@@ -3122,28 +3122,76 @@ |
} |
-// See http://www.ecma-international.org/ecma-262/6.0/#sec-function-calls. |
-void FullCodeGenerator::PushCalleeAndWithBaseObject(Call* expr) { |
- VariableProxy* callee = expr->expression()->AsVariableProxy(); |
- if (callee->var()->IsLookupSlot()) { |
+void FullCodeGenerator::VisitCall(Call* expr) { |
+#ifdef DEBUG |
+ // We want to verify that RecordJSReturnSite gets called on all paths |
+ // through this function. Avoid early returns. |
+ expr->return_is_recorded_ = false; |
+#endif |
+ |
+ Comment cmnt(masm_, "[ Call"); |
+ Expression* callee = expr->expression(); |
+ Call::CallType call_type = expr->GetCallType(isolate()); |
+ |
+ if (call_type == Call::POSSIBLY_EVAL_CALL) { |
+ // In a call to eval, we first call RuntimeHidden_ResolvePossiblyDirectEval |
+ // to resolve the function we need to call. Then we call the resolved |
+ // function using the given arguments. |
+ ZoneList<Expression*>* args = expr->arguments(); |
+ int arg_count = args->length(); |
+ |
+ { PreservePositionScope pos_scope(masm()->positions_recorder()); |
+ VisitForStackValue(callee); |
+ __ LoadRoot(a2, Heap::kUndefinedValueRootIndex); |
+ __ push(a2); // Reserved receiver slot. |
+ |
+ // Push the arguments. |
+ for (int i = 0; i < arg_count; i++) { |
+ VisitForStackValue(args->at(i)); |
+ } |
+ |
+ // Push a copy of the function (found below the arguments) and |
+ // resolve eval. |
+ __ ld(a1, MemOperand(sp, (arg_count + 1) * kPointerSize)); |
+ __ push(a1); |
+ EmitResolvePossiblyDirectEval(arg_count); |
+ |
+ // Touch up the stack with the resolved function. |
+ __ sd(v0, MemOperand(sp, (arg_count + 1) * kPointerSize)); |
+ |
+ PrepareForBailoutForId(expr->EvalOrLookupId(), NO_REGISTERS); |
+ } |
+ // Record source position for debugger. |
+ SetSourcePosition(expr->position()); |
+ CallFunctionStub stub(isolate(), arg_count, NO_CALL_FUNCTION_FLAGS); |
+ __ ld(a1, MemOperand(sp, (arg_count + 1) * kPointerSize)); |
+ __ CallStub(&stub); |
+ RecordJSReturnSite(expr); |
+ // Restore context register. |
+ __ ld(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); |
+ context()->DropAndPlug(1, v0); |
+ } else if (call_type == Call::GLOBAL_CALL) { |
+ EmitCallWithLoadIC(expr); |
+ } else if (call_type == Call::LOOKUP_SLOT_CALL) { |
+ // Call to a lookup slot (dynamically introduced variable). |
+ VariableProxy* proxy = callee->AsVariableProxy(); |
Label slow, done; |
- { |
- PreservePositionScope scope(masm()->positions_recorder()); |
+ { PreservePositionScope scope(masm()->positions_recorder()); |
// Generate code for loading from variables potentially shadowed |
// by eval-introduced variables. |
- EmitDynamicLookupFastCase(callee, NOT_INSIDE_TYPEOF, &slow, &done); |
+ EmitDynamicLookupFastCase(proxy, NOT_INSIDE_TYPEOF, &slow, &done); |
} |
__ bind(&slow); |
// Call the runtime to find the function to call (returned in v0) |
// and the object holding it (returned in v1). |
DCHECK(!context_register().is(a2)); |
- __ li(a2, Operand(callee->name())); |
+ __ li(a2, Operand(proxy->name())); |
__ Push(context_register(), a2); |
__ CallRuntime(Runtime::kLoadLookupSlot, 2); |
__ Push(v0, v1); // Function, receiver. |
- PrepareForBailoutForId(expr->LookupId(), NO_REGISTERS); |
+ PrepareForBailoutForId(expr->EvalOrLookupId(), NO_REGISTERS); |
// If fast case code has been generated, emit code to push the |
// function and receiver and have the slow path jump around this |
@@ -3160,66 +3208,9 @@ |
__ push(a1); |
__ bind(&call); |
} |
- } else { |
- VisitForStackValue(callee); |
- // refEnv.WithBaseObject() |
- __ LoadRoot(a2, Heap::kUndefinedValueRootIndex); |
- __ push(a2); // Reserved receiver slot. |
- } |
-} |
- |
- |
-void FullCodeGenerator::VisitCall(Call* expr) { |
-#ifdef DEBUG |
- // We want to verify that RecordJSReturnSite gets called on all paths |
- // through this function. Avoid early returns. |
- expr->return_is_recorded_ = false; |
-#endif |
- |
- Comment cmnt(masm_, "[ Call"); |
- Expression* callee = expr->expression(); |
- Call::CallType call_type = expr->GetCallType(isolate()); |
- |
- if (call_type == Call::POSSIBLY_EVAL_CALL) { |
- // In a call to eval, we first call RuntimeHidden_ResolvePossiblyDirectEval |
- // to resolve the function we need to call. Then we call the resolved |
- // function using the given arguments. |
- ZoneList<Expression*>* args = expr->arguments(); |
- int arg_count = args->length(); |
- |
- { PreservePositionScope pos_scope(masm()->positions_recorder()); |
- PushCalleeAndWithBaseObject(expr); |
- |
- // Push the arguments. |
- for (int i = 0; i < arg_count; i++) { |
- VisitForStackValue(args->at(i)); |
- } |
- |
- // Push a copy of the function (found below the arguments) and |
- // resolve eval. |
- __ ld(a1, MemOperand(sp, (arg_count + 1) * kPointerSize)); |
- __ push(a1); |
- EmitResolvePossiblyDirectEval(arg_count); |
- |
- // Touch up the stack with the resolved function. |
- __ sd(v0, MemOperand(sp, (arg_count + 1) * kPointerSize)); |
- |
- PrepareForBailoutForId(expr->EvalId(), NO_REGISTERS); |
- } |
- // Record source position for debugger. |
- SetSourcePosition(expr->position()); |
- CallFunctionStub stub(isolate(), arg_count, NO_CALL_FUNCTION_FLAGS); |
- __ ld(a1, MemOperand(sp, (arg_count + 1) * kPointerSize)); |
- __ CallStub(&stub); |
- RecordJSReturnSite(expr); |
- // Restore context register. |
- __ ld(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); |
- context()->DropAndPlug(1, v0); |
- } else if (call_type == Call::GLOBAL_CALL) { |
- EmitCallWithLoadIC(expr); |
- } else if (call_type == Call::LOOKUP_SLOT_CALL) { |
- // Call to a lookup slot (dynamically introduced variable). |
- PushCalleeAndWithBaseObject(expr); |
+ |
+ // The receiver is either the global receiver or an object found |
+ // by LoadContextSlot. |
EmitCall(expr); |
} else if (call_type == Call::PROPERTY_CALL) { |
Property* property = callee->AsProperty(); |