extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc ('k') | extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc

diff --git a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc

index 77561af2db9ae2aa99522fbb2396e78fff980e14..5e01c4461d45969e882dd0d5c00c043695c9319b 100644

--- a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc

+++ b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc

@@ -134,8 +134,9 @@ void TCPServerSocketEventDispatcher::AcceptCallback(

accept_info.client_socket_id = client_socket_id;

scoped_ptr<base::ListValue> args =

sockets_tcp_server::OnAccept::Create(accept_info);

- scoped_ptr<Event> event(

- new Event(sockets_tcp_server::OnAccept::kEventName, args.Pass()));

+ scoped_ptr<Event> event(new Event(events::UNKNOWN,

+ sockets_tcp_server::OnAccept::kEventName,

+ args.Pass()));

PostEvent(params, event.Pass());

// Post a task to delay the "accept" until the socket is available, as

@@ -153,7 +154,8 @@ void TCPServerSocketEventDispatcher::AcceptCallback(

scoped_ptr<base::ListValue> args =

sockets_tcp_server::OnAcceptError::Create(accept_error_info);

scoped_ptr<Event> event(

- new Event(sockets_tcp_server::OnAcceptError::kEventName, args.Pass()));

+ new Event(events::UNKNOWN,

+ sockets_tcp_server::OnAcceptError::kEventName, args.Pass()));

PostEvent(params, event.Pass());

// Since we got an error, the socket is now "paused" until the application