extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/serial/serial_event_dispatcher.cc ('k') | extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc

diff --git a/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc b/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc

index 0d52ae5937d2f13e0d0c15bd79a608b540819067..3a7bcc1851d3b6d9426fbbbf260ca1b3e1202d76 100644

--- a/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc

+++ b/extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc

@@ -131,8 +131,8 @@ void TCPSocketEventDispatcher::ReadCallback(

receive_info.data.assign(io_buffer->data(), io_buffer->data() + bytes_read);

scoped_ptr<base::ListValue> args =

sockets_tcp::OnReceive::Create(receive_info);

- scoped_ptr<Event> event(

- new Event(sockets_tcp::OnReceive::kEventName, args.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN, sockets_tcp::OnReceive::kEventName, args.Pass()));

PostEvent(params, event.Pass());

// Post a task to delay the read until the socket is available, as

@@ -152,8 +152,8 @@ void TCPSocketEventDispatcher::ReadCallback(

receive_error_info.result_code = bytes_read;

scoped_ptr<base::ListValue> args =

sockets_tcp::OnReceiveError::Create(receive_error_info);

- scoped_ptr<Event> event(

- new Event(sockets_tcp::OnReceiveError::kEventName, args.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN, sockets_tcp::OnReceiveError::kEventName, args.Pass()));

PostEvent(params, event.Pass());

// Since we got an error, the socket is now "paused" until the application