Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: extensions/browser/api/runtime/runtime_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaaaaase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/runtime/runtime_api.cc
diff --git a/extensions/browser/api/runtime/runtime_api.cc b/extensions/browser/api/runtime/runtime_api.cc
index 7f373c08b9c24d44a29ebba60e5b9725736cf521..d69d518172bd6038ac79d2211865f9ce2b4e9699 100644
--- a/extensions/browser/api/runtime/runtime_api.cc
+++ b/extensions/browser/api/runtime/runtime_api.cc
@@ -105,8 +105,8 @@ void DispatchOnStartupEventImpl(BrowserContext* browser_context,
}
scoped_ptr<base::ListValue> event_args(new base::ListValue());
- scoped_ptr<Event> event(
- new Event(runtime::OnStartup::kEventName, event_args.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, runtime::OnStartup::kEventName, event_args.Pass()));
EventRouter::Get(browser_context)
->DispatchEventToExtension(extension_id, event.Pass());
}
@@ -307,8 +307,8 @@ void RuntimeEventRouter::DispatchOnInstalledEvent(
}
EventRouter* event_router = EventRouter::Get(context);
DCHECK(event_router);
- scoped_ptr<Event> event(
- new Event(runtime::OnInstalled::kEventName, event_args.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, runtime::OnInstalled::kEventName, event_args.Pass()));
event_router->DispatchEventWithLazyListener(extension_id, event.Pass());
if (old_version.IsValid()) {
@@ -327,8 +327,9 @@ void RuntimeEventRouter::DispatchOnInstalledEvent(
sm_info->SetString(kInstallReason, kInstallReasonSharedModuleUpdate);
sm_info->SetString(kInstallPreviousVersion, old_version.GetString());
sm_info->SetString(kInstallId, extension_id);
- scoped_ptr<Event> sm_event(
- new Event(runtime::OnInstalled::kEventName, sm_event_args.Pass()));
+ scoped_ptr<Event> sm_event(new Event(events::UNKNOWN,
+ runtime::OnInstalled::kEventName,
+ sm_event_args.Pass()));
event_router->DispatchEventWithLazyListener((*i)->id(),
sm_event.Pass());
}
@@ -349,8 +350,8 @@ void RuntimeEventRouter::DispatchOnUpdateAvailableEvent(
args->Append(manifest->DeepCopy());
EventRouter* event_router = EventRouter::Get(context);
DCHECK(event_router);
- scoped_ptr<Event> event(
- new Event(runtime::OnUpdateAvailable::kEventName, args.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, runtime::OnUpdateAvailable::kEventName, args.Pass()));
event_router->DispatchEventToExtension(extension_id, event.Pass());
}
@@ -365,7 +366,8 @@ void RuntimeEventRouter::DispatchOnBrowserUpdateAvailableEvent(
EventRouter* event_router = EventRouter::Get(context);
DCHECK(event_router);
scoped_ptr<Event> event(
- new Event(runtime::OnBrowserUpdateAvailable::kEventName, args.Pass()));
+ new Event(events::UNKNOWN, runtime::OnBrowserUpdateAvailable::kEventName,
+ args.Pass()));
event_router->BroadcastEvent(event.Pass());
}
@@ -379,7 +381,7 @@ void RuntimeEventRouter::DispatchOnRestartRequiredEvent(
return;
scoped_ptr<Event> event(
- new Event(runtime::OnRestartRequired::kEventName,
+ new Event(events::UNKNOWN, runtime::OnRestartRequired::kEventName,
core_api::runtime::OnRestartRequired::Create(reason)));
EventRouter* event_router = EventRouter::Get(context);
DCHECK(event_router);

Powered by Google App Engine
This is Rietveld 408576698