extensions/browser/api/printer_provider/printer_provider_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_private/networking_private_event_router_nonchromeos.cc ('k') | extensions/browser/api/runtime/runtime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_api.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc

index 3cf447e9a51602483688c7ce19a6593698ed7c1a..5b8be0f56a84388207e63e3691e4d68d9430f262 100644

--- a/extensions/browser/api/printer_provider/printer_provider_api.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc

@@ -527,7 +527,8 @@ void PrinterProviderAPIImpl::DispatchGetPrintersRequested(

internal_args->AppendInteger(request_id);

scoped_ptr<Event> event(

- new Event(core_api::printer_provider::OnGetPrintersRequested::kEventName,

+ new Event(events::UNKNOWN,

+ core_api::printer_provider::OnGetPrintersRequested::kEventName,

internal_args.Pass()));

// This callback is called synchronously during |BroadcastEvent|, so

// Unretained is safe.

@@ -565,6 +566,7 @@ void PrinterProviderAPIImpl::DispatchGetCapabilityRequested(

internal_args->AppendString(internal_printer_id);

scoped_ptr<Event> event(new Event(

+ events::UNKNOWN,

core_api::printer_provider::OnGetCapabilityRequested::kEventName,

internal_args.Pass()));

@@ -612,9 +614,9 @@ void PrinterProviderAPIImpl::DispatchPrintRequested(

// custom bindings.

internal_args->AppendInteger(request_id);

internal_args->Append(print_job.ToValue().release());

- scoped_ptr<Event> event(

- new Event(core_api::printer_provider::OnPrintRequested::kEventName,

- internal_args.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN, core_api::printer_provider::OnPrintRequested::kEventName,

+ internal_args.Pass()));

event_router->DispatchEventToExtension(extension_id, event.Pass());

}

@@ -653,6 +655,7 @@ void PrinterProviderAPIImpl::DispatchGetUsbPrinterInfoRequested(

internal_args->AppendInteger(request_id);

internal_args->Append(usb_device.ToValue().release());

scoped_ptr<Event> event(new Event(

+ events::UNKNOWN,

core_api::printer_provider::OnGetUsbPrinterInfoRequested::kEventName,

internal_args.Pass()));

event_router->DispatchEventToExtension(extension_id, event.Pass());