Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: extensions/browser/api/app_runtime/app_runtime_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaaaaase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/alarms/alarm_manager.cc ('k') | extensions/browser/api/audio/audio_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/app_runtime/app_runtime_api.cc
diff --git a/extensions/browser/api/app_runtime/app_runtime_api.cc b/extensions/browser/api/app_runtime/app_runtime_api.cc
index e606dbca7116ce466507ed0ef5b1b9b3e419d121..7839b7255e536d8b4c1d9e535cebb2edb37bda97 100644
--- a/extensions/browser/api/app_runtime/app_runtime_api.cc
+++ b/extensions/browser/api/app_runtime/app_runtime_api.cc
@@ -30,8 +30,8 @@ void DispatchOnEmbedRequestedEventImpl(
content::BrowserContext* context) {
scoped_ptr<base::ListValue> args(new base::ListValue());
args->Append(app_embedding_request_data.release());
- scoped_ptr<Event> event(
- new Event(app_runtime::OnEmbedRequested::kEventName, args.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, app_runtime::OnEmbedRequested::kEventName, args.Pass()));
event->restrict_to_browser_context = context;
EventRouter::Get(context)
->DispatchEventWithLazyListener(extension_id, event.Pass());
@@ -53,8 +53,8 @@ void DispatchOnLaunchedEventImpl(const std::string& extension_id,
ExtensionsBrowserClient::Get()->IsRunningInForcedAppMode());
scoped_ptr<base::ListValue> args(new base::ListValue());
args->Append(launch_data.release());
- scoped_ptr<Event> event(
- new Event(app_runtime::OnLaunched::kEventName, args.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, app_runtime::OnLaunched::kEventName, args.Pass()));
event->restrict_to_browser_context = context;
EventRouter::Get(context)
->DispatchEventWithLazyListener(extension_id, event.Pass());
@@ -138,8 +138,8 @@ void AppRuntimeEventRouter::DispatchOnRestartedEvent(
BrowserContext* context,
const Extension* extension) {
scoped_ptr<base::ListValue> arguments(new base::ListValue());
- scoped_ptr<Event> event(
- new Event(app_runtime::OnRestarted::kEventName, arguments.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, app_runtime::OnRestarted::kEventName, arguments.Pass()));
event->restrict_to_browser_context = context;
EventRouter::Get(context)
->DispatchEventToExtension(extension->id(), event.Pass());
« no previous file with comments | « extensions/browser/api/alarms/alarm_manager.cc ('k') | extensions/browser/api/audio/audio_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698