extensions/browser/api/alarms/alarm_manager.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/alarms/alarm_manager.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/alarms/alarm_manager.cc

diff --git a/extensions/browser/api/alarms/alarm_manager.cc b/extensions/browser/api/alarms/alarm_manager.cc

index 9eccbfeda6363330fc584ac3925eccd95931e25f..7b61d81993d2dde7977f79440e7205f178d2080d 100644

--- a/extensions/browser/api/alarms/alarm_manager.cc

+++ b/extensions/browser/api/alarms/alarm_manager.cc

@@ -44,7 +44,7 @@ class DefaultAlarmDelegate : public AlarmManager::Delegate {

scoped_ptr<base::ListValue> args(new base::ListValue());

args->Append(alarm.js_alarm->ToValue().release());

scoped_ptr<Event> event(

- new Event(alarms::OnAlarm::kEventName, args.Pass()));

+ new Event(events::UNKNOWN, alarms::OnAlarm::kEventName, args.Pass()));

EventRouter::Get(browser_context_)

->DispatchEventToExtension(extension_id, event.Pass());

}

« no previous file with comments | « extensions/browser/PRESUBMIT.py ('k') | extensions/browser/api/app_runtime/app_runtime_api.cc » ('j') | no next file with comments »