chrome/browser/extensions/api/tabs/windows_event_router.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/windows_event_router.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_event_router.cc ('k') | chrome/browser/extensions/api/terminal/terminal_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/windows_event_router.cc

diff --git a/chrome/browser/extensions/api/tabs/windows_event_router.cc b/chrome/browser/extensions/api/tabs/windows_event_router.cc

index 52abe54b75041f12dd73e93525b00d122ade0a91..31a37655aa7774922c6cee476036aecaf5a3552d 100644

--- a/chrome/browser/extensions/api/tabs/windows_event_router.cc

+++ b/chrome/browser/extensions/api/tabs/windows_event_router.cc

@@ -138,7 +138,8 @@ void WindowsEventRouter::OnActiveWindowChanged(

focused_profile_ = window_profile;

focused_window_id_ = window_id;

- scoped_ptr<Event> event(new Event(windows::OnFocusChanged::kEventName,

+ scoped_ptr<Event> event(new Event(events::UNKNOWN,

+ windows::OnFocusChanged::kEventName,

make_scoped_ptr(new base::ListValue())));

event->will_dispatch_callback =

base::Bind(&WillDispatchWindowFocusedEvent,

@@ -150,7 +151,7 @@ void WindowsEventRouter::OnActiveWindowChanged(

void WindowsEventRouter::DispatchEvent(const std::string& event_name,

Profile* profile,

scoped_ptr<base::ListValue> args) {

- scoped_ptr<Event> event(new Event(event_name, args.Pass()));

+ scoped_ptr<Event> event(new Event(events::UNKNOWN, event_name, args.Pass()));

event->restrict_to_browser_context = profile;

EventRouter::Get(profile)->BroadcastEvent(event.Pass());

}