chrome/browser/extensions/api/tabs/tabs_event_router.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc ('k') | chrome/browser/extensions/api/tabs/windows_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc

index 6f5d5207b3a717a48fc2ac4b6d0551bd44d27064..5c187402a2778f007e44130141624c6594ad5c9f 100644

--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc

@@ -201,7 +201,8 @@ void TabsEventRouter::TabCreatedAt(WebContents* contents,

bool active) {

Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());

scoped_ptr<base::ListValue> args(new base::ListValue);

- scoped_ptr<Event> event(new Event(tabs::OnCreated::kEventName, args.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, tabs::OnCreated::kEventName, args.Pass()));

event->restrict_to_browser_context = profile;

event->user_gesture = EventRouter::USER_GESTURE_NOT_ENABLED;

event->will_dispatch_callback =

@@ -430,7 +431,7 @@ void TabsEventRouter::DispatchEvent(

if (!profile_->IsSameProfile(profile) || !event_router)

return;

- scoped_ptr<Event> event(new Event(event_name, args.Pass()));

+ scoped_ptr<Event> event(new Event(events::UNKNOWN, event_name, args.Pass()));

event->restrict_to_browser_context = profile;

event->user_gesture = user_gesture;

event_router->BroadcastEvent(event.Pass());

@@ -471,8 +472,8 @@ void TabsEventRouter::DispatchTabUpdatedEvent(

// WillDispatchTabUpdatedEvent.

Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());

- scoped_ptr<Event> event(

- new Event(tabs::OnUpdated::kEventName, args_base.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN, tabs::OnUpdated::kEventName, args_base.Pass()));

event->restrict_to_browser_context = profile;

event->user_gesture = EventRouter::USER_GESTURE_NOT_ENABLED;

event->will_dispatch_callback =