chrome/browser/extensions/api/debugger/debugger_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_api.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_api.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc

index 9dbe9b359e43c5dcbf4f3a511be51167f360d0b8..ee5d0ff36e8aa0bdf0d527e3d94e6a06b79b42ee 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc

@@ -399,7 +399,8 @@ void ExtensionDevToolsClientHost::SendDetachedEvent() {

scoped_ptr<base::ListValue> args(OnDetach::Create(debuggee_,

detach_reason_));

- scoped_ptr<Event> event(new Event(OnDetach::kEventName, args.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, OnDetach::kEventName, args.Pass()));

event->restrict_to_browser_context = profile_;

EventRouter::Get(profile_)

->DispatchEventToExtension(extension_id_, event.Pass());

@@ -459,7 +460,8 @@ void ExtensionDevToolsClientHost::DispatchProtocolMessage(

scoped_ptr<base::ListValue> args(

OnEvent::Create(debuggee_, method_name, params));

- scoped_ptr<Event> event(new Event(OnEvent::kEventName, args.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, OnEvent::kEventName, args.Pass()));

event->restrict_to_browser_context = profile_;

EventRouter::Get(profile_)

->DispatchEventToExtension(extension_id_, event.Pass());