chrome/browser/extensions/api/copresence/copresence_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/copresence/copresence_api.cc

diff --git a/chrome/browser/extensions/api/copresence/copresence_api.cc b/chrome/browser/extensions/api/copresence/copresence_api.cc

index e742da841c91e24021cc62016501cc2d2df2be5f..c47530e7147c265b785c3e9ce537634d936bf55d 100644

--- a/chrome/browser/extensions/api/copresence/copresence_api.cc

+++ b/chrome/browser/extensions/api/copresence/copresence_api.cc

@@ -148,7 +148,7 @@ void CopresenceService::HandleMessages(

// Send the messages to the client app.

scoped_ptr<Event> event(

- new Event(OnMessagesReceived::kEventName,

+ new Event(events::UNKNOWN, OnMessagesReceived::kEventName,

OnMessagesReceived::Create(subscription_id, api_messages),

browser_context_));

EventRouter::Get(browser_context_)

@@ -161,7 +161,7 @@ void CopresenceService::HandleStatusUpdate(

copresence::CopresenceStatus status) {

DCHECK_EQ(copresence::AUDIO_FAIL, status);

scoped_ptr<Event> event(

- new Event(OnStatusUpdated::kEventName,

+ new Event(events::UNKNOWN, OnStatusUpdated::kEventName,

OnStatusUpdated::Create(api::copresence::STATUS_AUDIOFAILED),

browser_context_));

EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass());

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_api.cc ('k') | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »