Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1200983004: Revert of [turbofan] Run DeadCodeElimination together with the advanced reducers. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Run DeadCodeElimination together with the advanced reducers. (patchset #1 id:1 of https://codereview.chromium.org/1206533002/) Reason for revert: Looks like this breaks Tests262. Original issue's description: > [turbofan] Run DeadCodeElimination together with the advanced reducers. > > This will immediately remove dead code from the graph once any of > the advanced reducers inserts it. Also changes the GraphReducer to > use the canonical Dead node for ReplaceWithValue. > > R=jarin@chromium.org > > Committed: https://crrev.com/88a40c5fb381924b1c0b2403dc582bceb2abe5da > Cr-Commit-Position: refs/heads/master@{#29217} TBR=jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a5af5127ec1a14722a0122637895da73a36e3587 Cr-Commit-Position: refs/heads/master@{#29220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -41 lines) Patch
M src/compiler/graph-reducer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +25 lines, -12 lines 0 comments Download
M src/compiler/pipeline.cc View 5 chunks +16 lines, -10 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 5 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [turbofan] Run DeadCodeElimination together with the advanced reducers.
5 years, 6 months ago (2015-06-23 09:38:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200983004/1
5 years, 6 months ago (2015-06-23 09:38:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 09:39:16 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 09:39:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5af5127ec1a14722a0122637895da73a36e3587
Cr-Commit-Position: refs/heads/master@{#29220}

Powered by Google App Engine
This is Rietveld 408576698