Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: sky/tools/skyanalyzer

Issue 1200953007: Move internals.dart out of Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: _____ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tools/skyanalyzer
diff --git a/sky/tools/skyanalyzer b/sky/tools/skyanalyzer
index 05f08c14b373dd5aef66ccd2e47cd04d6b9cfd86..19a75bea823a37e1e4f72962045bab01e3a8a178 100755
--- a/sky/tools/skyanalyzer
+++ b/sky/tools/skyanalyzer
@@ -48,14 +48,16 @@ def main():
args = parser.parse_args()
build_dir = args.build_dir
analyzer_path = os.path.join(SRC_ROOT, 'third_party/dart-sdk/dart-sdk/bin/dartanalyzer')
+ dart_builtin_natives_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin_natives.dart')
+ dart_mojo_internal_path = os.path.join(SRC_ROOT, 'mojo/public/dart/sdk_ext/internal.dart')
+ dart_sky_internals_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/sky_internals.dart')
dart_sky_path = os.path.join(build_dir, 'gen/sky/bindings/dart_sky.dart')
- dart_sky_internals_path = os.path.join(SRC_ROOT, 'sky/sdk/lib/internals.dart')
- dart_sky_builtin_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin.dart')
packages_root = os.path.join(build_dir, 'gen/dart-pkg/packages')
analyzer_args = [analyzer_path,
+ "--url-mapping=dart:mojo.internal,%s" % dart_mojo_internal_path,
"--url-mapping=dart:sky,%s" % dart_sky_path,
"--url-mapping=dart:sky.internals,%s" % dart_sky_internals_path,
- "--url-mapping=dart:sky_builtin,%s" % dart_sky_builtin_path,
+ "--url-mapping=dart:sky_builtin_natives,%s" % dart_builtin_natives_path,
"--package-root", packages_root,
"--package-warnings",
args.app_path

Powered by Google App Engine
This is Rietveld 408576698