Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: sky/engine/bindings/BUILD.gn

Issue 1200953007: Move internals.dart out of Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: _____ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/builtin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/BUILD.gn
diff --git a/sky/engine/bindings/BUILD.gn b/sky/engine/bindings/BUILD.gn
index 6c664dd9c4b80d9a098768b864dc47275cb3700f..6a1e406a844cf21b69896fac8e763d3e53f61ddc 100644
--- a/sky/engine/bindings/BUILD.gn
+++ b/sky/engine/bindings/BUILD.gn
@@ -60,11 +60,12 @@ action("generate_snapshot_bin") {
]
inputs = [
"//dart/runtime/tools/create_snapshot_bin.py",
- "//sky/engine/bindings/builtin.dart",
"//mojo/public/dart/sdk_ext/internal.dart",
"//mojo/public/dart/sdk_ext/src/handle_watcher.dart",
"//mojo/public/dart/sdk_ext/src/natives.dart",
"//mojo/public/dart/sdk_ext/src/timer_queue.dart",
+ "//sky/engine/bindings/builtin_natives.dart",
+ "//sky/engine/bindings/sky_internals.dart",
"snapshot.dart",
]
vm_isolate_snapshot = "$target_gen_dir/vm_isolate_snapshot.bin"
@@ -74,9 +75,13 @@ action("generate_snapshot_bin") {
isolate_snapshot,
]
- builtin_path = rebase_path("//sky/engine/bindings/builtin.dart")
+ dart_mojo_internal_path =
+ rebase_path("//mojo/public/dart/sdk_ext/internal.dart")
+ dart_sky_builtin_natives_path =
eseidel 2015/06/23 06:24:24 Why not just make it part of dart:sky?
abarth-chromium 2015/06/23 14:43:58 Yes, we should make it part of dart:sky. In this
+ rebase_path("//sky/engine/bindings/builtin_natives.dart")
+ dart_sky_internals_path =
+ rebase_path("//sky/engine/bindings/sky_internals.dart")
dart_sky_path = rebase_path("$bindings_output_dir/dart_sky.dart")
- internal_path = rebase_path("//mojo/public/dart/sdk_ext/internal.dart")
gen_snapshot_dir =
get_label_info("//dart/runtime/bin:gen_snapshot($host_toolchain)",
@@ -96,9 +101,10 @@ action("generate_snapshot_bin") {
rebase_path(isolate_snapshot, root_build_dir),
"--target_os",
target_os,
+ "--url_mapping=dart:mojo.internal,$dart_mojo_internal_path",
"--url_mapping=dart:sky,$dart_sky_path",
- "--url_mapping=dart:mojo.internal,$internal_path",
- "--url_mapping=dart:sky_builtin,$builtin_path",
+ "--url_mapping=dart:sky.internals,$dart_sky_internals_path",
+ "--url_mapping=dart:sky_builtin_natives,$dart_sky_builtin_natives_path",
]
}
« no previous file with comments | « no previous file | sky/engine/bindings/builtin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698