Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1200773003: Revert of [depot_tools] Find, upload and apply patchset dependencies (Closed)

Created:
5 years, 6 months ago by rmistry
Modified:
5 years, 6 months ago
Reviewers:
jrobbins, agable
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -125 lines) Patch
M apply_issue.py View 1 chunk +46 lines, -80 lines 0 comments Download
M git_cl.py View 1 chunk +0 lines, -22 lines 0 comments Download
M rietveld.py View 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/upload.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of [depot_tools] Find, upload and apply patchset dependencies
5 years, 6 months ago (2015-06-22 15:19:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200773003/1
5 years, 6 months ago (2015-06-22 15:19:41 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 15:19:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295782

Powered by Google App Engine
This is Rietveld 408576698