[Extensions] Kill off ExtensionMsg_AddMessageToConsole

extensions/renderer/script_context_set.h

Index: extensions/renderer/script_context_set.h
diff --git a/extensions/renderer/script_context_set.h b/extensions/renderer/script_context_set.h
index b7424ae48247de54b818e41ceb87e0d3790903f2..cfe96727a7fce116bf79e88a73e1cbcff7b8f0ee 100644
--- a/extensions/renderer/script_context_set.h
+++ b/extensions/renderer/script_context_set.h
@@ -77,6 +77,9 @@ class ScriptContextSet {
   // Gets the ScriptContext corresponding to the specified
   // v8::Context or NULL if no such context exists.
   ScriptContext* GetByV8Context(const v8::Local<v8::Context>& context) const;
+  // Static equivalent of the above.

[not at google - send to devlin, 2015/06/22 21:20:15]

I'd rather a static Get() method of ScriptContextSet, it composes with all the
other instances methods on ScriptContextSet, while this doesn't.

[Devlin, 2015/06/22 21:23:11]

But since ScriptContextSet can be null while testing, then everything needs to
do:
ScriptContext* script_context = nullptr;
ScriptContextSet* script_context_set = ScriptContextSet::Get();
if (script_context_set)  // ScriptContextSet can be null while testing
  script_context = script_context->FromV8Context(context);

and that's just annoying. :/  Since this is (currently) the only thing we need
statically, I figured we'd start here, and abstract away the nasty "maybe null"
part.

[not at google - send to devlin, 2015/06/22 21:26:38]

If you *promise* to pull ownership of ScriptContextSet off Dispatcher and into a
Singleton, ok.

+  static ScriptContext* GetContextByV8Context(
+      const v8::Local<v8::Context>& context);
 
   // Synchronously runs |callback| with each ScriptContext that belongs to
   // |extension_id| in |render_view|.