[Extensions] Kill off ExtensionMsg_AddMessageToConsole

extensions/renderer/script_context_set.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_SET_H_
 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_SET_H_
 
 #include <set>
 #include <string>
 
@@ skipping 59 matching lines @@
   // NULL if no such context exists.
   ScriptContext* GetCurrent() const;
 
   // Gets the ScriptContext corresponding to v8::Context::GetCalling(), or
   // NULL if no such context exists.
   ScriptContext* GetCalling() const;
 
   // Gets the ScriptContext corresponding to the specified
   // v8::Context or NULL if no such context exists.
   ScriptContext* GetByV8Context(const v8::Local<v8::Context>& context) const;
+  // Static equivalent of the above.

[not at google - send to devlin, 2015/06/22 21:20:15]

I'd rather a static Get() method of ScriptContextSet, it composes with all the
other instances methods on ScriptContextSet, while this doesn't.

[Devlin, 2015/06/22 21:23:11]

But since ScriptContextSet can be null while testing, then everything needs to
do:
ScriptContext* script_context = nullptr;
ScriptContextSet* script_context_set = ScriptContextSet::Get();
if (script_context_set)  // ScriptContextSet can be null while testing
  script_context = script_context->FromV8Context(context);

and that's just annoying. :/  Since this is (currently) the only thing we need
statically, I figured we'd start here, and abstract away the nasty "maybe null"
part.

[not at google - send to devlin, 2015/06/22 21:26:38]

If you *promise* to pull ownership of ScriptContextSet off Dispatcher and into a
Singleton, ok.

+  static ScriptContext* GetContextByV8Context(
+      const v8::Local<v8::Context>& context);
 
   // Synchronously runs |callback| with each ScriptContext that belongs to
   // |extension_id| in |render_view|.
   //
   // An empty |extension_id| will match all extensions, and a NULL |render_view|
   // will match all render views, but try to use the inline variants of these
   // methods instead.
   void ForEach(const std::string& extension_id,
                content::RenderView* render_view,
                const base::Callback<void(ScriptContext*)>& callback) const;
@@ skipping 46 matching lines @@
 
   // The set of all ScriptContexts we own.
   std::set<ScriptContext*> contexts_;
 
   DISALLOW_COPY_AND_ASSIGN(ScriptContextSet);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_SET_H_