chrome/browser/geolocation/geolocation_permission_context_extensions.cc - Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

Issue 1200503002: [Extensions] Kill off ExtensionMsg_AddMessageToConsole (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/mdns/mdns_api.cc ('K') | « chrome/browser/extensions/api/mdns/mdns_api.cc ('k') | chrome/browser/notifications/desktop_notification_service.cc » ('j') | chrome/browser/speech/extension_api/tts_engine_extension_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

index 3b109984b244cd082043bb32f8e6f4c6fd3553bc..91cbf503dfc28dbfcb0cfec5c4ed88fd7287dc4c 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

@@ -69,9 +69,8 @@ bool GeolocationPermissionContextExtensions::RequestPermission(

const extensions::Extension* extension =

extension_registry->enabled_extensions().GetExtensionOrAppByURL(

requesting_frame_origin);

- if (IsExtensionWithPermissionOrSuggestInConsole(

- APIPermission::kGeolocation, extension,

- web_contents->GetRenderViewHost())) {

+ if (IsExtensionWithPermissionOrSuggestInConsole(APIPermission::kGeolocation,

+ extension, web_contents)) {

// Make sure the extension is in the calling process.

if (extensions::ProcessMap::Get(profile_)->Contains(

extension->id(), request_id.render_process_id())) {