Remove unneeded WebGraphicsContext3D refs from content

Remove unneeded WebGraphicsContext3D refs from content

This is mostly mechanical, the only difference is that in places that rely
on the content context support the code now downcasts the cc::ContextProvider
pointer instead of downcasing the blink::WebGraphicsContext3D pointer.

BUG=181120
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243410

[danakj, 2014-01-06 20:59:36]

LGTM % abbreviations

https://codereview.chromium.org/120043005/diff/1/content/browser/aura/gpu_bro...
File content/browser/aura/gpu_browser_compositor_output_surface.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/browser/aura/gpu_bro...
content/browser/aura/gpu_browser_compositor_output_surface.cc:32:
ContextProviderCommandBuffer* provider_cb =
|provider_command_buffer|? or even just |command_buffer|? (cb is also used as a
shortcut for callback in places, i dislike both..)

https://codereview.chromium.org/120043005/diff/1/content/browser/aura/gpu_pro...
File content/browser/aura/gpu_process_transport_factory.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/browser/aura/gpu_pro...
content/browser/aura/gpu_process_transport_factory.cc:291:
ContextProviderCommandBuffer* provider_cb =
provider_command_buffer?

https://codereview.chromium.org/120043005/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/compositor_impl_android.cc:82:
content::ContextProviderCommandBuffer* provider_cb =
provider_command_buffer?

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/composi...
File content/renderer/gpu/compositor_output_surface.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/composi...
content/renderer/gpu/compositor_output_surface.cc:124:
ContextProviderCommandBuffer* provider_cb =
provider_command_buffer?

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
File content/renderer/gpu/mailbox_output_surface.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
content/renderer/gpu/mailbox_output_surface.cc:198:
context_provider_->IsContextLost());
Hm, I'm curious as I think I missed or forgot something here. Is this method
going to go away on ContextProvider eventually?

[jamesr, 2014-01-07 01:36:18]

ok, those renames all sound good.

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
File content/renderer/gpu/mailbox_output_surface.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
content/renderer/gpu/mailbox_output_surface.cc:198:
context_provider_->IsContextLost());
On 2014/01/06 20:59:37, danakj wrote:
> Hm, I'm curious as I think I missed or forgot something here. Is this method
> going to go away on ContextProvider eventually?

I think that asking the ContextProvider (instead of the context) if it is lost
is the way to do things since knowing if the context is lost requires querying
things that only the provider can know about like the state of the IPC channel.

[commit-bot: I haz the power, 2014-01-07 09:57:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/120043005/140001

[commit-bot: I haz the power, 2014-01-07 10:15:24]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[no sievers, 2014-01-07 16:36:51]

lgtm

https://codereview.chromium.org/120043005/diff/140001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.h (right):

https://codereview.chromium.org/120043005/diff/140001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.h:34: int
GetGPUProcessID();
Yea, I've been trying to remove this entirely :)
https://codereview.chromium.org/111063003/

[danakj, 2014-01-07 17:31:51]

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
File content/renderer/gpu/mailbox_output_surface.cc (right):

https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
content/renderer/gpu/mailbox_output_surface.cc:198:
context_provider_->IsContextLost());
On 2014/01/07 01:36:18, jamesr wrote:
> On 2014/01/06 20:59:37, danakj wrote:
> > Hm, I'm curious as I think I missed or forgot something here. Is this method
> > going to go away on ContextProvider eventually?
> 
> I think that asking the ContextProvider (instead of the context) if it is lost
> is the way to do things since knowing if the context is lost requires querying
> things that only the provider can know about like the state of the IPC
channel.

Yes I agree. Currently it just calls thru into the Context3D. I guess I'm
wondering if that's a long-term thing? Or how this method relates to the
DestroyedOnMainThread method.

[commit-bot: I haz the power, 2014-01-07 18:18:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/120043005/140001

[jamesr, 2014-01-07 18:18:57]

On 2014/01/07 17:31:51, danakj wrote:
>
https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
> File content/renderer/gpu/mailbox_output_surface.cc (right):
> 
>
https://codereview.chromium.org/120043005/diff/1/content/renderer/gpu/mailbox...
> content/renderer/gpu/mailbox_output_surface.cc:198:
> context_provider_->IsContextLost());
> On 2014/01/07 01:36:18, jamesr wrote:
> > On 2014/01/06 20:59:37, danakj wrote:
> > > Hm, I'm curious as I think I missed or forgot something here. Is this
method
> > > going to go away on ContextProvider eventually?
> > 
> > I think that asking the ContextProvider (instead of the context) if it is
lost
> > is the way to do things since knowing if the context is lost requires
querying
> > things that only the provider can know about like the state of the IPC
> channel.
> 
> Yes I agree. Currently it just calls thru into the Context3D.

Sort of - it calls WebGraphicsContext3DCommandBufferImpl::isContextLost(), which
is specific to this implementation.  IOW, going through the provider hides the
WGC3D part of the implementation.

> I guess I'm
> wondering if that's a long-term thing? Or how this method relates to the
> DestroyedOnMainThread method.

[commit-bot: I haz the power, 2014-01-07 20:50:07]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-07 21:06:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/120043005/140001

[commit-bot: I haz the power, 2014-01-07 22:29:30]

Change committed as 243410