Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1200413003: Disable "Ok Google" hotwording in open source builds by default. (Closed)

Created:
5 years, 6 months ago by Matt Giuca
Modified:
5 years, 6 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@hotword-compiletimedisable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable "Ok Google" hotwording in open source builds by default. The compile-time flag "enable_hotwording" is now tied to branding=Chrome (false by default unless making a Google Chrome build). Note: Chromium will no longer download/install the Hotword Shared Module, and will automatically remove the Hotword Shared Module on startup if it was previously installed. To keep this functionality, add "enable_hotwording=1" to GYP_DEFINES. BUG=500922 Committed: https://crrev.com/0366a5184a70b3eefb5fcef2c2e13721669f00d8 Cr-Commit-Position: refs/heads/master@{#335874}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Trigger on branding=Chrome, not buildtype=Official. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M build/common.gypi View 1 2 chunks +8 lines, -2 lines 2 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 5 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
Matt Giuca
The intention is to keep official builds the same as before, but disable this flag ...
5 years, 6 months ago (2015-06-24 00:46:20 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200413003/1
5 years, 6 months ago (2015-06-24 00:46:22 UTC) #4
Anand Mistry (off Chromium)
https://codereview.chromium.org/1200413003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1200413003/diff/1/build/common.gypi#newcode839 build/common.gypi:839: 'enable_hotwording%': 1, You want branding=="Chrome", not buildtype. buildtype controls ...
5 years, 6 months ago (2015-06-24 01:10:33 UTC) #5
Matt Giuca
https://codereview.chromium.org/1200413003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1200413003/diff/1/build/common.gypi#newcode839 build/common.gypi:839: 'enable_hotwording%': 1, On 2015/06/24 01:10:33, Anand Mistry wrote: > ...
5 years, 6 months ago (2015-06-24 01:41:55 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200413003/20001
5 years, 6 months ago (2015-06-24 01:42:13 UTC) #8
Nico
https://codereview.chromium.org/1200413003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1200413003/diff/20001/build/common.gypi#newcode841 build/common.gypi:841: ['branding=="Chrome"', { Isn't buildtype=Official a better check?
5 years, 6 months ago (2015-06-24 01:46:30 UTC) #9
Matt Giuca
https://codereview.chromium.org/1200413003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1200413003/diff/20001/build/common.gypi#newcode841 build/common.gypi:841: ['branding=="Chrome"', { On 2015/06/24 01:46:30, Nico wrote: > Isn't ...
5 years, 6 months ago (2015-06-24 01:59:47 UTC) #10
Nico
On 2015/06/24 01:59:47, Matt Giuca wrote: > https://codereview.chromium.org/1200413003/diff/20001/build/common.gypi > File build/common.gypi (right): > > https://codereview.chromium.org/1200413003/diff/20001/build/common.gypi#newcode841 ...
5 years, 6 months ago (2015-06-24 02:26:32 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-24 03:14:43 UTC) #13
Matt Giuca
> The way I look at it is that branding controls the branding and/or things ...
5 years, 6 months ago (2015-06-24 03:18:21 UTC) #14
Nico
On 2015/06/24 03:18:21, Matt Giuca wrote: > > The way I look at it is ...
5 years, 6 months ago (2015-06-24 03:22:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200413003/20001
5 years, 6 months ago (2015-06-24 05:36:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 05:41:46 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 05:42:34 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0366a5184a70b3eefb5fcef2c2e13721669f00d8
Cr-Commit-Position: refs/heads/master@{#335874}

Powered by Google App Engine
This is Rietveld 408576698