Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/BUILD.gn

Issue 1200413003: Disable "Ok Google" hotwording in open source builds by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hotword-compiletimedisable
Patch Set: Trigger on branding=Chrome, not buildtype=Official. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 63e9053cb1af5215aab9cf7d2fee2014a7d435e2..3a5093927d52190371cd90a714a2353f93a1a479 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -20,8 +20,10 @@ if (is_desktop_linux) {
}
declare_args() {
- # 'Ok Google' hotwording is enabled.
- enable_hotwording = true
+ # 'Ok Google' hotwording is disabled by default in open source builds. Set to
+ # true to enable. (This will download a closed-source NaCl module at startup.)
+ # Chrome-branded builds have this enabled by default.
+ enable_hotwording = is_chrome_branded
}
about_credits_file = "$target_gen_dir/about_credits.html"

Powered by Google App Engine
This is Rietveld 408576698