chrome/browser/extensions/api/commands/command_service.cc - Issue 1200393002: Add more string_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service.cc

Issue 1200393002: Add more string_util functions to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string

Patch Set: Android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/commands/command_service.cc

diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc

index 45be93b6823a8acbec5949112fb36b5b33c42adb..0f57c603125edcd8e5f822e25904dabd43083660 100644

--- a/chrome/browser/extensions/api/commands/command_service.cc

+++ b/chrome/browser/extensions/api/commands/command_service.cc

@@ -75,8 +75,8 @@ bool IsForCurrentPlatform(const std::string& key) {

std::string StripCurrentPlatform(const std::string& key) {

DCHECK(IsForCurrentPlatform(key));

std::string result = key;

- ReplaceFirstSubstringAfterOffset(&result, 0, Command::CommandPlatform() + ":",

- "");

+ base::ReplaceFirstSubstringAfterOffset(

+ &result, 0, Command::CommandPlatform() + ":", base::StringPiece());

return result;

}