fixes #168, dart:js implementation with a test

fixes #168, dart:js implementation with a test

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/90e63a5fa12e58c109fe9afffe51c24416007b82

[Jennifer Messerly, 2015-06-23 21:14:10]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-06-23 21:18:17]

Patchset #1 (id:1) has been deleted

[vsm, 2015-06-24 23:16:15]

lgtm

https://codereview.chromium.org/1200233004/diff/10001/test/browser/js_test.dart
File test/browser/js_test.dart (right):

https://codereview.chromium.org/1200233004/diff/10001/test/browser/js_test.da...
test/browser/js_test.dart:15: // import 'package:test/test.dart';
Do the tests here run yet? 

Are these tests the same as those under test/html/js_test in the main repo?

https://codereview.chromium.org/1200233004/diff/10001/test/browser/js_test.da...
test/browser/js_test.dart:712: final console = (window as dynamic).console;
Move the code below to a separate 'unittest' file?

https://codereview.chromium.org/1200233004/diff/10001/test/codegen/sunflower/...
File test/codegen/sunflower/dom.dart (right):

https://codereview.chromium.org/1200233004/diff/10001/test/codegen/sunflower/...
test/codegen/sunflower/dom.dart:8: @JsName()
Do we need both this and the dom.dart under test/browser?

https://codereview.chromium.org/1200233004/diff/10001/tool/input_sdk/lib/js/d...
File tool/input_sdk/lib/js/dart2js/js_dart2js.dart (right):

https://codereview.chromium.org/1200233004/diff/10001/tool/input_sdk/lib/js/d...
tool/input_sdk/lib/js/dart2js/js_dart2js.dart:122: return _wrapToDart(JS('',
'new #(...#)', ctor, arguments));
Well, that's a lot simpler...  :-)

https://codereview.chromium.org/1200233004/diff/10001/tool/input_sdk/lib/js/d...
tool/input_sdk/lib/js/dart2js/js_dart2js.dart:170: JS('', '#[#] = #',
convertedMap, key, _convert(o[key]));
Should we preserve the '=Object'?  We won't use it - at least not for a while,
but might make it easier to merge back with dart2js eventually.

[Jennifer Messerly, 2015-06-25 20:11:27]

Thanks! Split out the mini-test-framework ... really hope it goes away soon tho
:|

https://codereview.chromium.org/1200233004/diff/10001/test/browser/js_test.dart
File test/browser/js_test.dart (right):

https://codereview.chromium.org/1200233004/diff/10001/test/browser/js_test.da...
test/browser/js_test.dart:15: // import 'package:test/test.dart';
On 2015/06/24 23:16:15, vsm wrote:
> Do the tests here run yet? 
> 
> Are these tests the same as those under test/html/js_test in the main repo?

basically, yes & yes

I may have removed some commented out tests from the original. I tried to keep
everything that made sense.

https://codereview.chromium.org/1200233004/diff/10001/test/browser/js_test.da...
test/browser/js_test.dart:712: final console = (window as dynamic).console;
On 2015/06/24 23:16:15, vsm wrote:
> Move the code below to a separate 'unittest' file?

sure. I hope it doesn't stick around long, though.

https://codereview.chromium.org/1200233004/diff/10001/test/codegen/sunflower/...
File test/codegen/sunflower/dom.dart (right):

https://codereview.chromium.org/1200233004/diff/10001/test/codegen/sunflower/...
test/codegen/sunflower/dom.dart:8: @JsName()
On 2015/06/24 23:16:15, vsm wrote:
> Do we need both this and the dom.dart under test/browser?

unfortunately, yes. Our server won't follow "../" regardless of your working
directory. :\

https://codereview.chromium.org/1200233004/diff/10001/tool/input_sdk/lib/js/d...
File tool/input_sdk/lib/js/dart2js/js_dart2js.dart (right):

https://codereview.chromium.org/1200233004/diff/10001/tool/input_sdk/lib/js/d...
tool/input_sdk/lib/js/dart2js/js_dart2js.dart:170: JS('', '#[#] = #',
convertedMap, key, _convert(o[key]));
On 2015/06/24 23:16:15, vsm wrote:
> Should we preserve the '=Object'?  We won't use it - at least not for a while,
> but might make it easier to merge back with dart2js eventually.

hmm, I hope not :)

Not sure it ever makes sense to share SDK impl details. I mean, if we were going
to do that, everything in dart:core is a problem now, like arrays? we'd have to
stop using dart_runtime.js, switch to dart2js dart:mirrors add back all the code
Leaf cleaned up ... etc ...

Also, I don't know how to use dart2js type annotations, so if I'm trying to
write JS(...) builtin code with untested type annotations, it's not likely that
I'll get them right.

[Jennifer Messerly, 2015-06-25 20:18:56]

Committed patchset #3 (id:50001) manually as
90e63a5fa12e58c109fe9afffe51c24416007b82 (presubmit successful).