Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tool/input_sdk/patch/async_patch.dart

Issue 1200233004: fixes #168, dart:js implementation with a test (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix error (window not defined) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/lib/js/dart2js/js_dart2js.dart ('k') | tool/input_sdk/patch/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/patch/async_patch.dart
diff --git a/tool/input_sdk/patch/async_patch.dart b/tool/input_sdk/patch/async_patch.dart
index a7e65ae0d236085613ff36ac954bde9b19c54df6..eefc637dcc64de2a47110375ef761a2bcd2e7bfd 100644
--- a/tool/input_sdk/patch/async_patch.dart
+++ b/tool/input_sdk/patch/async_patch.dart
@@ -6,8 +6,7 @@
import 'dart:_js_helper' show
patch,
- Primitives,
- convertDartClosureToJS;
+ Primitives;
import 'dart:_isolate_helper' show
IsolateNatives,
TimerImpl,
@@ -46,8 +45,7 @@ class _AsyncRun {
f();
};
- var observer = JS('', 'new self.MutationObserver(#)',
- convertDartClosureToJS(internalCallback, 1));
+ var observer = JS('', 'new self.MutationObserver(#)', internalCallback);
JS('', '#.observe(#, { childList: true })',
observer, div);
@@ -74,8 +72,7 @@ class _AsyncRun {
callback();
};
enterJsAsync();
- JS('void', 'self.scheduleImmediate(#)',
- convertDartClosureToJS(internalCallback, 0));
+ JS('void', 'self.scheduleImmediate(#)', internalCallback);
}
static void _scheduleImmediateWithSetImmediate(void callback()) {
@@ -84,8 +81,7 @@ class _AsyncRun {
callback();
};
enterJsAsync();
- JS('void', 'self.setImmediate(#)',
- convertDartClosureToJS(internalCallback, 0));
+ JS('void', 'self.setImmediate(#)', internalCallback);
}
static void _scheduleImmediateWithTimer(void callback()) {
« no previous file with comments | « tool/input_sdk/lib/js/dart2js/js_dart2js.dart ('k') | tool/input_sdk/patch/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698