src/ia32/builtins-ia32.cc - Issue 1199983002: [strong] Implement strong property access semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 1199983002: [strong] Implement strong property access semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add TODOs Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/builtins-ia32.cc

diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc

index 40cfc80497f356d7c7c1ef702ace9cd9e9e70e5c..ef9f30d715106dea2224cab66c426bbc8842d75e 100644

--- a/src/ia32/builtins-ia32.cc

+++ b/src/ia32/builtins-ia32.cc

@@ -1077,7 +1077,8 @@ static void Generate_PushAppliedArguments(MacroAssembler* masm,

int index = feedback_vector->GetIndex(FeedbackVectorICSlot(0));

__ mov(slot, Immediate(Smi::FromInt(index)));

__ mov(vector, Immediate(feedback_vector));

- Handle<Code> ic = KeyedLoadICStub(masm->isolate()).GetCode();

+ Handle<Code> ic =

+ KeyedLoadICStub(masm->isolate(), LoadICState(kNoExtraICState)).GetCode();

__ call(ic, RelocInfo::CODE_TARGET);

// It is important that we do not have a test instruction after the

// call. A test instruction after the call is used to indicate that

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »