Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 1199983002: [strong] Implement strong property access semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add TODOs Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1059 matching lines...) Expand 10 before | Expand all | Expand 10 after
1070 __ bind(&loop); 1070 __ bind(&loop);
1071 __ mov(receiver, Operand(ebp, argumentsOffset)); // load arguments 1071 __ mov(receiver, Operand(ebp, argumentsOffset)); // load arguments
1072 1072
1073 // Use inline caching to speed up access to arguments. 1073 // Use inline caching to speed up access to arguments.
1074 FeedbackVectorSpec spec(0, Code::KEYED_LOAD_IC); 1074 FeedbackVectorSpec spec(0, Code::KEYED_LOAD_IC);
1075 Handle<TypeFeedbackVector> feedback_vector = 1075 Handle<TypeFeedbackVector> feedback_vector =
1076 masm->isolate()->factory()->NewTypeFeedbackVector(&spec); 1076 masm->isolate()->factory()->NewTypeFeedbackVector(&spec);
1077 int index = feedback_vector->GetIndex(FeedbackVectorICSlot(0)); 1077 int index = feedback_vector->GetIndex(FeedbackVectorICSlot(0));
1078 __ mov(slot, Immediate(Smi::FromInt(index))); 1078 __ mov(slot, Immediate(Smi::FromInt(index)));
1079 __ mov(vector, Immediate(feedback_vector)); 1079 __ mov(vector, Immediate(feedback_vector));
1080 Handle<Code> ic = KeyedLoadICStub(masm->isolate()).GetCode(); 1080 Handle<Code> ic =
1081 KeyedLoadICStub(masm->isolate(), LoadICState(kNoExtraICState)).GetCode();
1081 __ call(ic, RelocInfo::CODE_TARGET); 1082 __ call(ic, RelocInfo::CODE_TARGET);
1082 // It is important that we do not have a test instruction after the 1083 // It is important that we do not have a test instruction after the
1083 // call. A test instruction after the call is used to indicate that 1084 // call. A test instruction after the call is used to indicate that
1084 // we have generated an inline version of the keyed load. In this 1085 // we have generated an inline version of the keyed load. In this
1085 // case, we know that we are not generating a test instruction next. 1086 // case, we know that we are not generating a test instruction next.
1086 1087
1087 // Push the nth argument. 1088 // Push the nth argument.
1088 __ push(eax); 1089 __ push(eax);
1089 1090
1090 // Update the index on the stack and in register key. 1091 // Update the index on the stack and in register key.
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
1727 1728
1728 __ bind(&ok); 1729 __ bind(&ok);
1729 __ ret(0); 1730 __ ret(0);
1730 } 1731 }
1731 1732
1732 #undef __ 1733 #undef __
1733 } // namespace internal 1734 } // namespace internal
1734 } // namespace v8 1735 } // namespace v8
1735 1736
1736 #endif // V8_TARGET_ARCH_IA32 1737 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698