Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1199933005: Fix HTML string methods to not depend on replace method (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix HTML string methods to not depend on replace method Before this we were using String.prototype.replace. Now we call the internal StringReplace instead. BUG=v8:4221 LOG=N R=adamk, littledan CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/81f2c4404795146924f94c5858c31873eaeac976 Cr-Commit-Position: refs/heads/master@{#29206}

Patch Set 1 #

Patch Set 2 : git rebase #

Patch Set 3 : Fix syntax error after git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/string.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/string-html.js View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
adamk
lgtm
5 years, 6 months ago (2015-06-22 18:17:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199933005/1
5 years, 6 months ago (2015-06-22 18:40:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/67943)
5 years, 6 months ago (2015-06-22 19:40:02 UTC) #5
arv (Not doing code reviews)
On 2015/06/22 19:40:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-22 19:55:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199933005/20001
5 years, 6 months ago (2015-06-22 20:11:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/3870)
5 years, 6 months ago (2015-06-22 20:20:03 UTC) #11
arv (Not doing code reviews)
Fix syntax error after git rebase
5 years, 6 months ago (2015-06-22 20:44:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199933005/40001
5 years, 6 months ago (2015-06-22 20:47:20 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-22 21:55:49 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 21:56:04 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/81f2c4404795146924f94c5858c31873eaeac976
Cr-Commit-Position: refs/heads/master@{#29206}

Powered by Google App Engine
This is Rietveld 408576698