src/string.js - Issue 1199933005: Fix HTML string methods to not depend on replace method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 1199933005: Fix HTML string methods to not depend on replace method (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix syntax error after git rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index cf70d40c85b8f165c14216f025ce40da703f4891..d8b37e28a981c8c85bef62f12f2e2881677f4fde 100644

--- a/src/string.js

+++ b/src/string.js

@@ -846,7 +846,7 @@ function StringFromCharCode(code) {

// ES6 draft, revision 26 (2014-07-18), section B.2.3.2.1

function HtmlEscape(str) {

- return TO_STRING_INLINE(str).replace(/"/g, """);

+ return %_CallFunction(TO_STRING_INLINE(str), /"/g, """, StringReplace);

}

« no previous file with comments | « no previous file | test/mjsunit/es6/string-html.js » ('j') | no next file with comments »