tests/CachedDecodingPixelRefTest.cpp - Issue 1199473002: change old picture serialization to really handle images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/CachedDecodingPixelRefTest.cpp

Issue 1199473002: change old picture serialization to really handle images (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix check in new_array function Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/CachedDecodingPixelRefTest.cpp

diff --git a/tests/CachedDecodingPixelRefTest.cpp b/tests/CachedDecodingPixelRefTest.cpp

index 66e5273625df385d772cc33e666a7fbff6df5a1e..465b69b8564393db4f355fa22186c1c9a7be1aa7 100644

--- a/tests/CachedDecodingPixelRefTest.cpp

+++ b/tests/CachedDecodingPixelRefTest.cpp

@@ -249,7 +249,7 @@ static void check_pixelref(TestImageGenerator::TestType type,

// Ignore factory; use global cache.

success = SkCachingPixelRef::Install(gen.detach(), &lazy);

} else {

- success = SkInstallDiscardablePixelRef(gen.detach(), &lazy, factory);

+ success = SkInstallDiscardablePixelRef(gen.detach(), NULL, &lazy, factory);

}

REPORTER_ASSERT(reporter, success);

if (TestImageGenerator::kSucceedGetPixels_TestType == type) {

« no previous file with comments | « src/utils/SkLua.cpp ('k') | tests/DrawBitmapRectTest.cpp » ('j') | no next file with comments »