src/utils/SkLua.cpp - Issue 1199473002: change old picture serialization to really handle images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkLua.cpp

Issue 1199473002: change old picture serialization to really handle images (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix check in new_array function Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkLua.cpp

diff --git a/src/utils/SkLua.cpp b/src/utils/SkLua.cpp

index 11d9b2938c66afab3b6a837086a78dfdbeb58f03..cee4d4ded8eb13026f7defc59c65ecc1129efed4 100644

--- a/src/utils/SkLua.cpp

+++ b/src/utils/SkLua.cpp

@@ -2007,7 +2007,7 @@ static int lsk_loadImage(lua_State* L) {

const char* name = lua_tolstring(L, 1, NULL);

SkAutoDataUnref data(SkData::NewFromFileName(name));

if (data.get()) {

- SkImage* image = SkImage::NewFromData(data);

+ SkImage* image = SkImage::NewFromEncoded(data);

if (image) {

push_ref(L, image)->unref();

return 1;

« no previous file with comments | « src/ports/SkImageDecoder_CG.cpp ('k') | tests/CachedDecodingPixelRefTest.cpp » ('j') | no next file with comments »