Work around for HDMI audio output rediscovering transistion loss.

Work around for HDMI audio output rediscovering transistion loss.

When audio output is playing on HDMI device, each time user opens or closes the lid of the device, changes the resolution of the hdmi display, or the device resumes after suspension, there is a short period of time the audio will be played on internal speaker, then goes back to hdmi device., The root cause is due to the fact that cras will lose hdmi output audio device for a short period of time and rediscover it later during the transition period of these scenarios. The hot plug cause the internal speaker be selected as an alternative active output device during the transition period. For some platform, the transition period is quite long as several seconds and it is an annoying user experience.

I've made a workaround in CrasAudioHandler to mute the output during the hdmi rediscovering grace period, so that the audio will NOT be leaked.

BUG=503667
Committed: https://crrev.com/c770dc778a8d2aedf0cc2f9a803a75db4211e4ac
Cr-Commit-Position: refs/heads/master@{#336681}

[jennyz, 2015-06-24 21:57:45]

jennyz@chromium.org changed reviewers:
+ cychiang@chromium.org

[cychiang, 2015-06-26 10:00:22]

lgtm

https://codereview.chromium.org/1199413008/diff/1/ash/system/audio/tray_audio.cc
File ash/system/audio/tray_audio.cc (right):

https://codereview.chromium.org/1199413008/diff/1/ash/system/audio/tray_audio...
ash/system/audio/tray_audio.cc:141: void
TrayAudio::ChangeInternalSpeakerChannelMode() {
I guess you actually move three OnDisplay methods. But what's the purpose of
moving these functions ?

https://codereview.chromium.org/1199413008/diff/1/ash/system/chromeos/audio/t...
File ash/system/chromeos/audio/tray_audio_chromeos.cc (right):

https://codereview.chromium.org/1199413008/diff/1/ash/system/chromeos/audio/t...
ash/system/chromeos/audio/tray_audio_chromeos.cc:82: // transition, we don't
need to restart HDMI re-discovering grace period
does the transition mean resolution transition, or include other transitions ?

https://codereview.chromium.org/1199413008/diff/1/ash/system/chromeos/audio/t...
File ash/system/chromeos/audio/tray_audio_chromeos.h (right):

https://codereview.chromium.org/1199413008/diff/1/ash/system/chromeos/audio/t...
ash/system/chromeos/audio/tray_audio_chromeos.h:40: // Overriden from
chromeos::PowerManagerClient::Observer.
Overridden

https://codereview.chromium.org/1199413008/diff/1/chromeos/audio/cras_audio_h...
File chromeos/audio/cras_audio_handler.h (right):

https://codereview.chromium.org/1199413008/diff/1/chromeos/audio/cras_audio_h...
chromeos/audio/cras_audio_handler.h:314: void
SetHDMIRediscoverGracePeriodForTesting(int during_in_ms);
should name it duration_in_ms  ?

[jennyz, 2015-06-29 20:04:50]

Patchset #2 (id:20001) has been deleted

[jennyz, 2015-06-29 20:49:41]

https://codereview.chromium.org/1199413008/diff/1/ash/system/audio/tray_audio.cc
File ash/system/audio/tray_audio.cc (right):

https://codereview.chromium.org/1199413008/diff/1/ash/system/audio/tray_audio...
ash/system/audio/tray_audio.cc:141: void
TrayAudio::ChangeInternalSpeakerChannelMode() {
On 2015/06/26 10:00:21, cychiang wrote:
> I guess you actually move three OnDisplay methods. But what's the purpose of
> moving these functions ?

It enables the derived class TrayAudioChromeos to overrides these three
functions.

https://codereview.chromium.org/1199413008/diff/1/ash/system/chromeos/audio/t...
File ash/system/chromeos/audio/tray_audio_chromeos.cc (right):

https://codereview.chromium.org/1199413008/diff/1/ash/system/chromeos/audio/t...
ash/system/chromeos/audio/tray_audio_chromeos.cc:82: // transition, we don't
need to restart HDMI re-discovering grace period
On 2015/06/26 10:00:21, cychiang wrote:
> does the transition mean resolution transition, or include other transitions ?

This will be called during the resolution changes caused by user changing device
resolution, as well as display configuration changes.

https://codereview.chromium.org/1199413008/diff/1/chromeos/audio/cras_audio_h...
File chromeos/audio/cras_audio_handler.h (right):

https://codereview.chromium.org/1199413008/diff/1/chromeos/audio/cras_audio_h...
chromeos/audio/cras_audio_handler.h:314: void
SetHDMIRediscoverGracePeriodForTesting(int during_in_ms);
On 2015/06/26 10:00:21, cychiang wrote:
> should name it duration_in_ms  ?

Done.

[jennyz, 2015-06-29 20:49:45]

The CQ bit was checked by jennyz@chromium.org

[jennyz, 2015-06-29 20:49:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
cychiang@chromium.org
Link to the patchset: https://codereview.chromium.org/1199413008/#ps40001
(title: "Fix a nit.")

[commit-bot: I haz the power, 2015-06-29 20:50:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1199413008/40001

[commit-bot: I haz the power, 2015-06-29 20:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-29 20:50:14]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jennyz, 2015-06-29 20:58:15]

jennyz@chromium.org changed reviewers:
+ hshi@chromium.org

[jennyz, 2015-06-29 21:01:12]

jennyz@chromium.org changed reviewers:
+ stevenjb@chromium.org
- hshi@chromium.org

[stevenjb, 2015-06-29 21:57:20]

https://codereview.chromium.org/1199413008/diff/40001/chromeos/audio/cras_aud...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/1199413008/diff/40001/chromeos/audio/cras_aud...
chromeos/audio/cras_audio_handler.cc:602: LOG(WARNING) << "Mute the output
during HDMI re-discovering grace period";
VLOG?

https://codereview.chromium.org/1199413008/diff/40001/chromeos/audio/cras_aud...
chromeos/audio/cras_audio_handler.cc:1013: LOG(WARNING) << "HDMI output
re-discover grace period ends.";
VLOG here and below also?

[jennyz, 2015-06-29 22:07:30]

https://codereview.chromium.org/1199413008/diff/40001/chromeos/audio/cras_aud...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/1199413008/diff/40001/chromeos/audio/cras_aud...
chromeos/audio/cras_audio_handler.cc:602: LOG(WARNING) << "Mute the output
during HDMI re-discovering grace period";
On 2015/06/29 21:57:20, stevenjb wrote:
> VLOG?

Done.

https://codereview.chromium.org/1199413008/diff/40001/chromeos/audio/cras_aud...
chromeos/audio/cras_audio_handler.cc:1013: LOG(WARNING) << "HDMI output
re-discover grace period ends.";
On 2015/06/29 21:57:20, stevenjb wrote:
> VLOG here and below also?

Done.

[stevenjb, 2015-06-29 22:10:43]

lgtm

[jennyz, 2015-06-29 23:00:58]

The CQ bit was checked by jennyz@chromium.org

[jennyz, 2015-06-29 23:00:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
cychiang@chromium.org
Link to the patchset: https://codereview.chromium.org/1199413008/#ps60001
(title: "Changed to VLOG.")

[commit-bot: I haz the power, 2015-06-29 23:01:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1199413008/60001

[commit-bot: I haz the power, 2015-06-29 23:46:13]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-06-29 23:48:25]

Patchset 3 (id:??) landed as
https://crrev.com/c770dc778a8d2aedf0cc2f9a803a75db4211e4ac
Cr-Commit-Position: refs/heads/master@{#336681}