Issue 119933003: Adding win8/ and chrome_frame/ to _CheckForString16() whitelist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119933003: Adding win8/ and chrome_frame/ to _CheckForString16() whitelist. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding win8/ and chrome_frame/ to _CheckForString16() whitelist. TBR=joi@chromium.org BUG=329295 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242142

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/119933003/1

7 years ago (2013-12-20 17:51:56 UTC) #2

Jói

7 years ago (2013-12-21 08:47:05 UTC) #4

LGTM


On Fri, Dec 20, 2013 at 5:49 PM, <dbeam@chromium.org> wrote:

> Reviewers: Jói,
>
> Description:
> Adding win8/ and chrome_frame/ to _CheckForString16() whitelist.
>
> TBR=joi@chromium.org
> BUG=329295
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/119933003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+2, -0 lines):
>   M PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> diff --git a/PRESUBMIT.py b/PRESUBMIT.py
> index 9bb1471cbed6ae9c37ed36022b878fe58fc95d21..
> fb1fa983e7469898a1b803e87904098e3a4662cf 100644
> --- a/PRESUBMIT.py
> +++ b/PRESUBMIT.py
> @@ -1199,6 +1199,7 @@ def _CheckForString16(input_api, output_api):
>            r'^apps[\\\/]',
>            r'^ash[\\\/]',
>            r'^chrome[\\\/]',
> +          r'^chrome_frame[\\\/]',
>            r'^chromeos[\\\/]',
>            r'^components[\\\/]',
>            r'^content[\\\/]',
> @@ -1212,6 +1213,7 @@ def _CheckForString16(input_api, output_api):
>            r'^tools[\\\/]',
>            r'^ui[\\\/]',
>            r'^webkit[\\\/]',
> +          r'^win8[\\\/]',
>        ),
>        black_list=(_EXCLUDED_PATHS + _TEST_CODE_EXCLUDED_PATHS +
>                    input_api.DEFAULT_BLACK_LIST))
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages