Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Side by Side Diff: PRESUBMIT.py

Issue 119933003: Adding win8/ and chrome_frame/ to _CheckForString16() whitelist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 return results 1192 return results
1193 1193
1194 1194
1195 def _CheckForString16(input_api, output_api): 1195 def _CheckForString16(input_api, output_api):
1196 file_filter = lambda f: input_api.FilterSourceFile(f, 1196 file_filter = lambda f: input_api.FilterSourceFile(f,
1197 white_list=( 1197 white_list=(
1198 r'^android_webview[\\\/]', 1198 r'^android_webview[\\\/]',
1199 r'^apps[\\\/]', 1199 r'^apps[\\\/]',
1200 r'^ash[\\\/]', 1200 r'^ash[\\\/]',
1201 r'^chrome[\\\/]', 1201 r'^chrome[\\\/]',
1202 r'^chrome_frame[\\\/]',
1202 r'^chromeos[\\\/]', 1203 r'^chromeos[\\\/]',
1203 r'^components[\\\/]', 1204 r'^components[\\\/]',
1204 r'^content[\\\/]', 1205 r'^content[\\\/]',
1205 r'^device[\\\/]', 1206 r'^device[\\\/]',
1206 r'^ipc[\\\/]', 1207 r'^ipc[\\\/]',
1207 r'^net[\\\/]', 1208 r'^net[\\\/]',
1208 r'^ppapi[\\\/]', 1209 r'^ppapi[\\\/]',
1209 r'^printing[\\\/]', 1210 r'^printing[\\\/]',
1210 r'^rlz[\\\/]', 1211 r'^rlz[\\\/]',
1211 r'^skia[\\\/]', 1212 r'^skia[\\\/]',
1212 r'^tools[\\\/]', 1213 r'^tools[\\\/]',
1213 r'^ui[\\\/]', 1214 r'^ui[\\\/]',
1214 r'^webkit[\\\/]', 1215 r'^webkit[\\\/]',
1216 r'^win8[\\\/]',
1215 ), 1217 ),
1216 black_list=(_EXCLUDED_PATHS + _TEST_CODE_EXCLUDED_PATHS + 1218 black_list=(_EXCLUDED_PATHS + _TEST_CODE_EXCLUDED_PATHS +
1217 input_api.DEFAULT_BLACK_LIST)) 1219 input_api.DEFAULT_BLACK_LIST))
1218 1220
1219 unprefixed = [] 1221 unprefixed = []
1220 for f in input_api.AffectedFiles(file_filter=file_filter): 1222 for f in input_api.AffectedFiles(file_filter=file_filter):
1221 unprefixed.extend(_CheckForString16InFile(input_api, f)) 1223 unprefixed.extend(_CheckForString16InFile(input_api, f))
1222 1224
1223 if not unprefixed: 1225 if not unprefixed:
1224 return [] 1226 return []
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1476 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1478 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1477 1479
1478 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1480 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1479 # unless they're .gyp(i) files as changes to those files can break the gyp 1481 # unless they're .gyp(i) files as changes to those files can break the gyp
1480 # step on that bot. 1482 # step on that bot.
1481 if (not all(re.search('^chrome', f) for f in files) or 1483 if (not all(re.search('^chrome', f) for f in files) or
1482 any(re.search('\.gypi?$', f) for f in files)): 1484 any(re.search('\.gypi?$', f) for f in files)):
1483 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1485 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1484 1486
1485 return trybots 1487 return trybots
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698