Tighten up media::DecoderBuffer API contract for end of stream buffers.

Tighten up media::DecoderBuffer API contract for end of stream buffers.

Folks shouldn't be calling methods on end of stream buffers since the definition is undefined.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177550

[xhwang, 2013-01-17 23:55:13]

lgtm % comment

https://codereview.chromium.org/11993002/diff/4001/media/base/decoder_buffer.h
File media/base/decoder_buffer.h (right):

https://codereview.chromium.org/11993002/diff/4001/media/base/decoder_buffer....
media/base/decoder_buffer.h:51: // is disallowed.
This means the caller/user of a DecoderBuffer should always call IsEndOfStream()
to make sure it's not EOS buffer before it can call any other methods. Can we
make this even clear in a class level comment?

[scherkus (not reviewing), 2013-01-18 00:06:36]

want to take a quick look at my comment?

open to suggestions on how to word it etc

https://codereview.chromium.org/11993002/diff/4001/media/base/decoder_buffer.h
File media/base/decoder_buffer.h (right):

https://codereview.chromium.org/11993002/diff/4001/media/base/decoder_buffer....
media/base/decoder_buffer.h:51: // is disallowed.
On 2013/01/17 23:55:13, xhwang wrote:
> This means the caller/user of a DecoderBuffer should always call
IsEndOfStream()
> to make sure it's not EOS buffer before it can call any other methods. Can we
> make this even clear in a class level comment?

Done + DataBuffer.

[xhwang, 2013-01-18 00:23:04]

I think the comment is good! When a developer hit the CHECK and comes to see
this class, he/she will understand immediately :)

still lgtm