Issue 119913003: Enable Component Updater on Android

Issue 119913003: Enable Component Updater on Android (Closed)

Created:
7 years ago by aurimas (slooooooooow)

Modified:
7 years ago

Reviewers:
cpu_(ooo_6.6-7.5), Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable Component Updater on Android Enable CRL set fetching Enable WebUI for chrome://components BUG=116838 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242237

Patch Set 2 : cpu nits #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	1	4 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View		4 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hello Carlos, Please take a look at this CL. Thanks, Aurimas

7 years ago (2013-12-20 18:45:45 UTC) #1

cpu_(ooo_6.6-7.5)

lgtm https://codereview.chromium.org/119913003/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/119913003/diff/1/chrome/browser/chrome_browser_main.cc#newcode409 chrome/browser/chrome_browser_main.cc:409: #if !defined(OS_ANDROID) please use the style you used ...

7 years ago (2013-12-20 20:33:36 UTC) #2

aurimas (slooooooooow)

https://codereview.chromium.org/119913003/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/119913003/diff/1/chrome/browser/chrome_browser_main.cc#newcode409 chrome/browser/chrome_browser_main.cc:409: #if !defined(OS_ANDROID) On 2013/12/20 20:33:36, cpu wrote: > please ...

7 years ago (2013-12-20 21:48:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/119913003/100001

7 years ago (2013-12-20 22:42:36 UTC) #6

aurimas (slooooooooow)

7 years ago (2013-12-21 05:24:16 UTC) #8

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/120433002/ by aurimas@chromium.org.

The reason for reverting is: Broke ComponentUpdaterTest on Android. Need to
update expectations..

Expand Messages | Collapse Messages