Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5679)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 119913003: Enable Component Updater on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cpu nits Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/common/url_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index 9ce190d3a4e3ad0bf9f6f997c26974222e38da7a..f04b6fb55b286fdd38d890de38f090bde3024157 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -244,6 +244,8 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
return &NewWebUI<ExternalWebDialogUI>;
if (url.host() == chrome::kChromeUICloudPrintSetupHost)
return &NewWebUI<WebDialogUI>;
+ if (url.host() == chrome::kChromeUIComponentsHost)
+ return &NewWebUI<ComponentsUI>;
if (url.spec() == chrome::kChromeUIConstrainedHTMLTestURL)
return &NewWebUI<ConstrainedWebDialogUI>;
if (url.host() == chrome::kChromeUICrashesHost)
@@ -351,9 +353,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
// Android does not support plugins for now.
if (url.host() == chrome::kChromeUIPluginsHost)
return &NewWebUI<PluginsUI>;
- // Android does not support components for now.
- if (url.host() == chrome::kChromeUIComponentsHost)
- return &NewWebUI<ComponentsUI>;
// Settings are implemented with native UI elements on Android.
if (url.host() == chrome::kChromeUISettingsFrameHost)
return &NewWebUI<options::OptionsUI>;
@@ -618,6 +617,10 @@ base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (!content::HasWebUIScheme(page_url))
return NULL;
+ if (page_url.host() == chrome::kChromeUIComponentsHost)
+ return ComponentsUI::GetFaviconResourceBytes(scale_factor);
+ return NULL;
+
#if defined(OS_WIN)
if (page_url.host() == chrome::kChromeUIConflictsHost)
return ConflictsUI::GetFaviconResourceBytes(scale_factor);
@@ -660,10 +663,5 @@ base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (page_url.host() == chrome::kChromeUIPluginsHost)
return PluginsUI::GetFaviconResourceBytes(scale_factor);
- // Android doesn't use the components pages.
- if (page_url.host() == chrome::kChromeUIComponentsHost)
- return ComponentsUI::GetFaviconResourceBytes(scale_factor);
#endif
-
- return NULL;
}
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/common/url_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698