Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1198983002: [turbofan] Revive the VectorSlotPair and also put feedback on JSCallFunction. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Revive the VectorSlotPair and also put feedback on JSCallFunction. We resurrect the VectorSlotPair in order to be able to separate the feedback input for the compiler from the actual type feedback vector that is required to meet the IC requirements at runtime. This will allow us to for example use feedback from a different context or divide the type feedback vector into two separate vectors, without having to touch the compiler. It'll allow use to load the vector from the shared function info at runtime, while still consuming feedback in the compiler (i.e. we don't rely on the feedback vector node to be a heap constant). R=mvstanton@chromium.org Committed: https://crrev.com/d4f70f8ce8f523f6ea5986b59923c133747338c6 Cr-Commit-Position: refs/heads/master@{#29185}

Patch Set 1 #

Patch Set 2 : Try to address compilation error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -228 lines) Patch
M src/compiler/ast-graph-builder.h View 6 chunks +12 lines, -17 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 54 chunks +115 lines, -118 lines 0 comments Download
M src/compiler/js-operator.h View 11 chunks +61 lines, -53 lines 0 comments Download
M src/compiler/js-operator.cc View 9 chunks +29 lines, -26 lines 0 comments Download
M src/handles.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils.h View 2 chunks +10 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-22 11:06:01 UTC) #1
Benedikt Meurer
Hey Michael, This is the change we were talking about. Mostly straight forward. Please take ...
5 years, 6 months ago (2015-06-22 11:07:08 UTC) #2
mvstanton
Okay, LGTM...
5 years, 6 months ago (2015-06-22 11:24:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198983002/20001
5 years, 6 months ago (2015-06-22 12:03:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 12:08:10 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 12:08:29 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4f70f8ce8f523f6ea5986b59923c133747338c6
Cr-Commit-Position: refs/heads/master@{#29185}

Powered by Google App Engine
This is Rietveld 408576698