Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1198653004: Update client side navigator.connect API to use ServicePortCollection [3/3] (Closed)

Created:
5 years, 6 months ago by Marijn Kruisselbrink
Modified:
5 years, 5 months ago
Reviewers:
scheib, Nate Chapin
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@serviceport-part2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update client side navigator.connect API to use ServicePortCollection [3/3] This is part of a series of patches to update the client side API of what was formerly known as navigator.connect to follow the new spec based on navigator.services and a new ServicePort type. This patch removes the old client side API from blink, and removes now redundant code from the layout tests. [1/3] https://codereview.chromium.org/1191393003 Blink side changes [2/3] https://codereview.chromium.org/1192713004 Content side changes [3/3] https://codereview.chromium.org/1198653004 This patch BUG=426458 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198024

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -226 lines) Patch
M LayoutTests/http/tests/navigatorconnect/connect.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/postmessage.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/connect-helper.js View 1 chunk +10 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/connect-tests.js View 2 chunks +23 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/test-helpers.js View 3 chunks +32 lines, -36 lines 0 comments Download
M Source/modules/modules.gypi View 1 3 chunks +0 lines, -5 lines 0 comments Download
D Source/modules/navigatorconnect/NavigatorConnect.h View 1 chunk +0 lines, -28 lines 0 comments Download
D Source/modules/navigatorconnect/NavigatorConnect.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/modules/navigatorconnect/NavigatorConnect.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/modules/navigatorconnect/WorkerNavigatorConnect.h View 1 chunk +0 lines, -24 lines 0 comments Download
D Source/modules/navigatorconnect/WorkerNavigatorConnect.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D public/platform/WebNavigatorConnectProvider.h View 1 chunk +0 lines, -34 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Marijn Kruisselbrink
5 years, 6 months ago (2015-06-22 17:48:53 UTC) #4
scheib
LGTM
5 years, 6 months ago (2015-06-24 23:07:16 UTC) #5
Marijn Kruisselbrink
+japhet for public/ OWNERS
5 years, 5 months ago (2015-06-29 20:31:45 UTC) #7
Nate Chapin
lgtm
5 years, 5 months ago (2015-06-29 20:51:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198653004/60001
5 years, 5 months ago (2015-06-29 21:45:25 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 22:14:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198024

Powered by Google App Engine
This is Rietveld 408576698