Issue 119863002: Revert 242026 "Get Windows 8 ASH to work again. "

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119863002: Revert 242026 "Get Windows 8 ASH to work again. " (Closed)

Created:
7 years ago by kinuko

Modified:
7 years ago

Reviewers:
ananta

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 242026 "Get Windows 8 ASH to work again. " After this was landed almost all tests in ash_unittests are crashing. http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20Aura&number=13804 http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/13804/steps/ash_unittests/logs/stdio > Get Windows 8 ASH to work again. > > This broke in revision 236017 which creates the compositor in the ctor of the RemoteRootWindowHostWin class. > This in turn uses the GetAcceleratedWidget function which returns the desktop window as the metro viewer is not yet > connected to the browser. > > Moving the CreateCompositor call to the RemoteRootWindowHostWin::Connected function fixes this. > > BUG=none > TBR=ben > > Review URL: https://codereview.chromium.org/64363004 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242053

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	trunk/src/ui/aura/remote_root_window_host_win.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r242053.