Get Windows 8 ASH to work again.

Get Windows 8 ASH to work again. 

This broke in revision 236017 which creates the compositor in the ctor of the RemoteRootWindowHostWin class.
This in turn uses the GetAcceleratedWidget function which returns the desktop window as the metro viewer is not yet
connected to the browser.

Moving the CreateCompositor call to the RemoteRootWindowHostWin::Connected function fixes this.

BUG=none
TBR=ben

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242026

[Ben Goodger (Google), 2013-11-20 00:50:38]

lgtm thanks!

-Ben


On Tue, Nov 19, 2013 at 4:13 PM, <ananta@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Get Windows 8 ASH to work again.
>
> This broke in revision 236017 which creates the compositor in the ctor of
> the
> RemoteRootWindowHostWin class.
> This in turn uses the GetAcceleratedWidget function which returns the
> desktop
> window as the metro viewer is not yet
> connected to the browser.
>
> Moving the CreateCompositor call to the RemoteRootWindowHostWin::Connected
> function fixes this.
>
> BUG=none
> TBR=ben
>
> Please review this at https://codereview.chromium.org/64363004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files (+1, -1 lines):
>   M     ui/aura/remote_root_window_host_win.cc
>
>
> Index: ui/aura/remote_root_window_host_win.cc
> ===================================================================
> --- ui/aura/remote_root_window_host_win.cc      (revision 236034)
> +++ ui/aura/remote_root_window_host_win.cc      (working copy)
> @@ -136,7 +136,6 @@
>        ignore_mouse_moves_until_set_cursor_ack_(false),
>        event_flags_(0) {
>    prop_.reset(new ui::ViewProp(NULL, kRootWindowHostWinKey, this));
> -  CreateCompositor(GetAcceleratedWidget());
>  }
>
>  RemoteRootWindowHostWin::~RemoteRootWindowHostWin() {
> @@ -147,6 +146,7 @@
>    CHECK(host_ == NULL);
>    host_ = host;
>    remote_window_ = remote_window;
> +  CreateCompositor(GetAcceleratedWidget());
>  }
>
>  void RemoteRootWindowHostWin::Disconnected() {
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2013-11-20 01:45:07]

I reverted the underlying change, so you can sit on this for the time
being. I will apply this locally before I reland after the merging ends.

-Ben


On Tue, Nov 19, 2013 at 4:50 PM, Ben Goodger (Google) <ben@chromium.org>wrote:

> lgtm thanks!
>
> -Ben
>
>
> On Tue, Nov 19, 2013 at 4:13 PM, <ananta@chromium.org> wrote:
>
>> Reviewers: Ben Goodger (Google),
>>
>> Description:
>> Get Windows 8 ASH to work again.
>>
>> This broke in revision 236017 which creates the compositor in the ctor of
>> the
>> RemoteRootWindowHostWin class.
>> This in turn uses the GetAcceleratedWidget function which returns the
>> desktop
>> window as the metro viewer is not yet
>> connected to the browser.
>>
>> Moving the CreateCompositor call to the RemoteRootWindowHostWin::
>> Connected
>> function fixes this.
>>
>> BUG=none
>> TBR=ben
>>
>> Please review this at https://codereview.chromium.org/64363004/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files (+1, -1 lines):
>>   M     ui/aura/remote_root_window_host_win.cc
>>
>>
>> Index: ui/aura/remote_root_window_host_win.cc
>> ===================================================================
>> --- ui/aura/remote_root_window_host_win.cc      (revision 236034)
>> +++ ui/aura/remote_root_window_host_win.cc      (working copy)
>> @@ -136,7 +136,6 @@
>>        ignore_mouse_moves_until_set_cursor_ack_(false),
>>        event_flags_(0) {
>>    prop_.reset(new ui::ViewProp(NULL, kRootWindowHostWinKey, this));
>> -  CreateCompositor(GetAcceleratedWidget());
>>  }
>>
>>  RemoteRootWindowHostWin::~RemoteRootWindowHostWin() {
>> @@ -147,6 +146,7 @@
>>    CHECK(host_ == NULL);
>>    host_ = host;
>>    remote_window_ = remote_window;
>> +  CreateCompositor(GetAcceleratedWidget());
>>  }
>>
>>  void RemoteRootWindowHostWin::Disconnected() {
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2013-12-19 20:20:11]

I'm going to land this again this afternoon as I relanded the change that this
depends on.

[commit-bot: I haz the power, 2013-12-19 22:46:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ananta@chromium.org/64363004/50001

[commit-bot: I haz the power, 2013-12-20 07:25:40]

Change committed as 242026