Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1198483002: Only register the reporter component on Google Chrome builds (Closed)

Created:
5 years, 6 months ago by MAD
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only register the reporter component on Google Chrome builds Simple enough change to TBR an OWNER. TBR=jochen@chromium.org BUG=None Committed: https://crrev.com/4d6fa4db1675305420c988195c17240357883e63 Cr-Commit-Position: refs/heads/master@{#335623}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged master #

Patch Set 3 : Use proper #define :-) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
MAD
Do you agree that I can TBR an OWNER for such a change? Thanks! BYE ...
5 years, 6 months ago (2015-06-19 13:31:14 UTC) #2
MAD
5 years, 6 months ago (2015-06-19 22:07:26 UTC) #4
MAD
Ping?
5 years, 6 months ago (2015-06-22 18:24:16 UTC) #5
csharp
https://codereview.chromium.org/1198483002/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/1198483002/diff/1/chrome/browser/chrome_browser_main.cc#newcode472 chrome/browser/chrome_browser_main.cc:472: #if defined(OFFICIAL_BUILD) IS official build only true for Chrome ...
5 years, 6 months ago (2015-06-22 18:31:43 UTC) #6
MAD
Good catch, I was using the wrong one... THanks! BYE MAD https://codereview.chromium.org/1198483002/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): ...
5 years, 6 months ago (2015-06-22 23:21:43 UTC) #7
robertshield
Sorry for the delay, this LGTM
5 years, 6 months ago (2015-06-22 23:45:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198483002/40001
5 years, 6 months ago (2015-06-23 00:41:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/30945)
5 years, 6 months ago (2015-06-23 01:25:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198483002/40001
5 years, 6 months ago (2015-06-23 02:36:07 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-23 03:15:01 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4d6fa4db1675305420c988195c17240357883e63 Cr-Commit-Position: refs/heads/master@{#335623}
5 years, 6 months ago (2015-06-23 03:16:03 UTC) #17
csharp
5 years, 6 months ago (2015-06-23 13:28:04 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698