Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1198463002: Prepare layout test expectations for V8 roll (Closed)

Created:
3 years, 10 months ago by wingo
Modified:
3 years, 10 months ago
CC:
blink-reviews, Michael Achenbach, rossberg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Prepare layout test expectations for V8 roll BUG=502243 R=rossberg@chromium.org LOG=N Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197492

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
wingo
Please let me know if I should choose a Blink reviewer rather than a V8 ...
3 years, 10 months ago (2015-06-19 13:19:26 UTC) #1
rossberg
On 2015/06/19 13:19:26, wingo wrote: > Please let me know if I should choose a ...
3 years, 10 months ago (2015-06-19 13:28:16 UTC) #2
wingo
On 2015/06/19 13:28:16, rossberg wrote: > On 2015/06/19 13:19:26, wingo wrote: > > Please let ...
3 years, 10 months ago (2015-06-19 14:29:23 UTC) #4
arv (Not doing code reviews)
lgtm https://codereview.chromium.org/1198463002/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1198463002/diff/1/LayoutTests/TestExpectations#newcode604 LayoutTests/TestExpectations:604: # crbug.com/320477 [ Debug ] inspector/sources/debugger-pause/debugger-pause-in-internal.html [ Pass ...
3 years, 10 months ago (2015-06-19 15:43:20 UTC) #5
wingo
tx for the review https://codereview.chromium.org/1198463002/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1198463002/diff/1/LayoutTests/TestExpectations#newcode604 LayoutTests/TestExpectations:604: # crbug.com/320477 [ Debug ] ...
3 years, 10 months ago (2015-06-19 16:13:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198463002/20001
3 years, 10 months ago (2015-06-19 16:13:27 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2015-06-19 18:19:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197492

Powered by Google App Engine
This is Rietveld 408576698