Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: Source/modules/fetch/CompositeDataConsumerHandleTest.cpp

Issue 1198443002: Fetch DataConsumerHandle test cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tee
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/fetch/CompositeDataConsumerHandleTest.cpp
diff --git a/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp b/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp
index 0f97575d1bb41c129de8a65385700791d6cc5e41..61bc574a1eeb5944ff45190415ba2396ab76971f 100644
--- a/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp
+++ b/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp
@@ -56,14 +56,17 @@ public:
{
m_context = Context::create();
m_waitableEvent = adoptPtr(Platform::current()->createWaitableEvent());
- m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
-
- readingThread()->postTask(FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
- m_waitableEvent->wait();
+ postTaskAndWait(updatingThread(), FROM_HERE, new Task(threadSafeBind(&Self::createHandle, this)));
+ postTaskAndWait(readingThread(), FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
}
private:
+ void createHandle()
+ {
+ m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
+ m_waitableEvent->signal();
+ }
void obtainReader()
{
m_reader = m_handle->obtainReader(&m_client);
@@ -86,14 +89,18 @@ public:
{
m_context = Context::create();
m_waitableEvent = adoptPtr(Platform::current()->createWaitableEvent());
- m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
- readingThread()->postTask(FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
-
- m_waitableEvent->wait();
+ postTaskAndWait(updatingThread(), FROM_HERE, new Task(threadSafeBind(&Self::createHandle, this)));
+ postTaskAndWait(readingThread(), FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
}
private:
+ void createHandle()
+ {
+ m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
+ m_waitableEvent->signal();
+ }
+
void obtainReader()
{
m_reader = m_handle->obtainReader(&m_client);
@@ -117,14 +124,18 @@ public:
{
m_context = Context::create();
m_waitableEvent = adoptPtr(Platform::current()->createWaitableEvent());
- m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
- readingThread()->postTask(FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
-
- m_waitableEvent->wait();
+ postTaskAndWait(updatingThread(), FROM_HERE, new Task(threadSafeBind(&Self::createHandle, this)));
+ postTaskAndWait(readingThread(), FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
}
private:
+ void createHandle()
+ {
+ m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
+ m_waitableEvent->signal();
+ }
+
void obtainReader()
{
m_reader = m_handle->obtainReader(&m_client);
@@ -149,14 +160,18 @@ public:
m_context = Context::create();
m_waitableEvent = adoptPtr(Platform::current()->createWaitableEvent());
m_updateEvent = adoptPtr(Platform::current()->createWaitableEvent());
- m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
-
- readingThread()->postTask(FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
- m_waitableEvent->wait();
+ postTaskAndWait(updatingThread(), FROM_HERE, new Task(threadSafeBind(&Self::createHandle, this)));
+ postTaskAndWait(readingThread(), FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
}
private:
+ void createHandle()
+ {
+ m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
+ m_waitableEvent->signal();
+ }
+
void obtainReader()
{
m_reader = m_handle->obtainReader(&m_client);
@@ -190,14 +205,18 @@ public:
{
m_context = Context::create();
m_waitableEvent = adoptPtr(Platform::current()->createWaitableEvent());
- m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
- readingThread()->postTask(FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
-
- m_waitableEvent->wait();
+ postTaskAndWait(updatingThread(), FROM_HERE, new Task(threadSafeBind(&Self::createHandle, this)));
+ postTaskAndWait(readingThread(), FROM_HERE, new Task(threadSafeBind(&Self::obtainReader, this)));
}
private:
+ void createHandle()
+ {
+ m_handle = CompositeDataConsumerHandle::create(adoptPtr(new DataConsumerHandle("handle1", m_context)));
+ m_waitableEvent->signal();
+ }
+
void obtainReader()
{
m_reader = m_handle->obtainReader(&m_client);
« no previous file with comments | « no previous file | Source/modules/fetch/DataConsumerHandleTestUtil.h » ('j') | Source/modules/fetch/DataConsumerHandleTestUtil.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698