Fetch DataConsumerHandle test cleanup

Source/modules/fetch/DataConsumerHandleTestUtil.cpp

Index: Source/modules/fetch/DataConsumerHandleTestUtil.cpp
diff --git a/Source/modules/fetch/DataConsumerHandleTestUtil.cpp b/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..19c76b9dbae1b1c574896af456652052acbea50c
--- /dev/null
+++ b/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
@@ -0,0 +1,56 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/fetch/DataConsumerHandleTestUtil.h"
+
+#include "bindings/core/v8/DOMWrapperWorld.h"
+
+namespace blink {
+
+DataConsumerHandleTestUtil::Thread::Thread(const char* name, InitializationPolicy initializationPolicy)
+    : m_thread(WebThreadSupportingGC::create(name))
+    , m_initializationPolicy(initializationPolicy)
+    , m_waitableEvent(adoptPtr(Platform::current()->createWaitableEvent()))
+{
+    m_thread->postTask(FROM_HERE, new Task(threadSafeBind(&Thread::initialize, AllowCrossThreadAccess(this))));
+    m_waitableEvent->wait();
+}
+
+DataConsumerHandleTestUtil::Thread::~Thread()
+{
+    m_thread->postTask(FROM_HERE, new Task(threadSafeBind(&Thread::shutdown, AllowCrossThreadAccess(this))));
+    m_waitableEvent->wait();
+}
+
+void DataConsumerHandleTestUtil::Thread::initialize()
+{
+    if (m_initializationPolicy >= ScriptExecution) {
+        m_isolateHolder = adoptPtr(new gin::IsolateHolder());
+        isolate()->Enter();
+    }
+    m_thread->initialize();
+    if (m_initializationPolicy >= ScriptExecution) {
+        v8::HandleScope handleScope(isolate());
+        m_scriptState = ScriptState::create(v8::Context::New(isolate()), DOMWrapperWorld::create(isolate()));

[Nico, 2015/08/26 03:54:51]

It looks like this is leaked somehow, see e.g.
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan%20tester/...
:

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x585328 in __interceptor_malloc
/b/build/slave/ClangToTLinuxASan/build/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cc:40
    #1 0x1d8bc30 in partitionAllocGenericFlags
third_party/WebKit/Source/wtf/PartitionAlloc.h:691:20
    #2 0x1d8bc30 in partitionAllocGeneric
third_party/WebKit/Source/wtf/PartitionAlloc.h:707
    #3 0x1d8bc30 in WTF::fastMalloc(unsigned long)
third_party/WebKit/Source/wtf/FastMalloc.cpp:56
    #4 0x6ad1b04 in operator new
third_party/WebKit/Source/wtf/RefCounted.h:166:5
    #5 0x6ad1b04 in blink::ScriptState::create(v8::Local\u003Cv8::Context>,
WTF::PassRefPtr\u003Cblink::DOMWrapperWorld>)
third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp:17
    #6 0xfc1b17 in blink::DataConsumerHandleTestUtil::Thread::initialize()
third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp:36:25
    #7 0x8e44c21 in Run base/bind_internal.h:157:12
    #8 0x8e44c21 in MakeItSo base/bind_internal.h:293
    #9 0x8e44c21 in base::internal::Invoker\u003Cbase::IndexSequence\u003C0ul>,
base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid
(*)(scoped_ptr\u003Cblink::WebThread::Task,
base::DefaultDeleter\u003Cblink::WebThread::Task> >)>, void
(scoped_ptr\u003Cblink::WebThread::Task,
base::DefaultDeleter\u003Cblink::WebThread::Task> >),
base::internal::TypeList\u003Cbase::internal::PassedWrapper\u003Cscoped_ptr\u003Cblink::WebThread::Task,
base::DefaultDeleter\u003Cblink::WebThread::Task> > > > >,
base::internal::TypeList\u003Cbase::internal::UnwrapTraits\u003Cbase::internal::PassedWrapper\u003Cscoped_ptr\u003Cblink::WebThread::Task,
base::DefaultDeleter\u003Cblink::WebThread::Task> > > > >,
base::internal::InvokeHelper\u003Cfalse, void,
base::internal::RunnableAdapter\u003Cvoid
(*)(scoped_ptr\u003Cblink::WebThread::Task,
base::DefaultDeleter\u003Cblink::WebThread::Task> >)>,
base::internal::TypeList\u003Cscoped_ptr\u003Cblink::WebThread::Task,
base::DefaultDeleter\u003Cblink::WebThread::Task> > > >, void
()>::Run(base::internal::BindStateBase*) base/bind_internal.h:343
    #10 0x193d5a4 in Run base/callback.h:396:12


Do you have an idea how this could happen?

+    }
+    if (m_initializationPolicy >= WithExecutionContext) {
+        m_executionContext = adoptRefWillBeNoop(new NullExecutionContext());
+    }
+    m_waitableEvent->signal();
+}
+
+void DataConsumerHandleTestUtil::Thread::shutdown()
+{
+    m_executionContext = nullptr;
+    m_scriptState = nullptr;
+    m_thread->shutdown();
+    if (m_isolateHolder) {
+        isolate()->Exit();
+        m_isolateHolder = nullptr;
+    }
+    m_waitableEvent->signal();
+}
+
+} // namespace blink