Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1198433002: *** NOT FOR LANDING *** mapLocalToContainer and offsetFromContainer cleanup. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

*** NOT FOR LANDING *** mapLocalToContainer and offsetFromContainer cleanup. The ultimate goal is to get rid of that multicol kludge in LayoutBoxModelObject::mapAbsoluteToLocalPoint(). After I managed to untangle multicol and other stuff from offsetFromContainer(), it became easy to split it into proper sub-class implementations again (that's patch set 7 and 8). I'm not sure if that's desirable, though. We'll get more function calls than before this way, and, after all, most objects in the containing block chain are LayoutBox-derived, so we'll have a lot of LayoutBox::offsetFromContainer() calling LayoutBoxModelObject::offsetFromContainer() calling LayoutObject::offsetFromContainer().

Patch Set 1 : Remove LayoutInline::mapLocalToContainer #

Patch Set 2 : Remove LayoutBox::mapLocalToContainer #

Patch Set 3 : Remove LayoutInline::offsetFromContainer #

Patch Set 4 : Remove LayoutBox::offsetFromContainer #

Patch Set 5 : Don't let offsetFromContainer() translate for multicol. Get rid of kludge in LayoutBoxModelObject::… #

Patch Set 6 : Move multicol specific stuff out from LayoutBoxModelObject::mapAbsoluteToLocalPoint #

Patch Set 7 : Actually, now LayoutBox has offsetFromContainer() work that it can easily do on its own. #

Patch Set 8 : There's also work that LayoutBoxModelObject::offsetFromContainer could do instead of LayoutObject. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -198 lines) Patch
M Source/core/editing/Caret.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBox.h View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -77 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 1 2 3 4 5 6 7 3 chunks +12 lines, -16 lines 0 comments Download
M Source/core/layout/LayoutFlowThread.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutInline.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 4 chunks +57 lines, -22 lines 0 comments Download
M Source/core/layout/LayoutTableCell.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTableCell.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698