|
*** NOT FOR LANDING *** mapLocalToContainer and offsetFromContainer cleanup.
The ultimate goal is to get rid of that multicol kludge in
LayoutBoxModelObject::mapAbsoluteToLocalPoint().
After I managed to untangle multicol and other stuff from offsetFromContainer(),
it became easy to split it into proper sub-class implementations again
(that's patch set 7 and 8).
I'm not sure if that's desirable, though. We'll get more function calls than
before this way, and, after all, most objects in the containing block chain are
LayoutBox-derived, so we'll have a lot of LayoutBox::offsetFromContainer() calling LayoutBoxModelObject::offsetFromContainer() calling LayoutObject::offsetFromContainer().
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+93 lines, -198 lines) |
Patch |
 |
M |
Source/core/editing/Caret.cpp
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutBox.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutBox.cpp
|
View
|
1
2
3
4
5
6
|
2 chunks |
+3 lines, -77 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutBoxModelObject.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutBoxModelObject.cpp
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+12 lines, -16 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutFlowThread.h
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutInline.h
|
View
|
1
2
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutInline.cpp
|
View
|
1
2
|
1 chunk |
+0 lines, -67 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutMultiColumnFlowThread.h
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutMultiColumnFlowThread.cpp
|
View
|
1
2
3
4
5
|
2 chunks |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutObject.h
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutObject.cpp
|
View
|
1
2
3
4
5
6
7
|
4 chunks |
+57 lines, -22 lines |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutTableCell.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/layout/LayoutTableCell.cpp
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|