Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1198393002: HTMLTableCellElement type changed from signed to unsinged (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
tkent, philipj_slow
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

HTMLTableCellElement type changed from signed to unsinged HTMLTable colSpan, rowSpan and cellIndex attirbute type changed to unsigned. Its usage in LayoutTableCell is already an unsigned value. BUG=496400 R=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197687

Patch Set 1 #

Patch Set 2 : Reverted cellIndex changes and updated layout test o correspond with the changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M LayoutTests/fast/dom/HTMLTableCellElement/colspan-attribute.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableCellElement/colspan-attribute-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableCellElement/rowspan-attribute.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableCellElement/rowspan-attribute-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 4 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.idl View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198393002/1
5 years, 6 months ago (2015-06-22 15:06:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198393002/20001
5 years, 6 months ago (2015-06-22 16:00:35 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 17:28:43 UTC) #7
Habib Virji
PTAL
5 years, 6 months ago (2015-06-22 21:28:57 UTC) #8
Rick Byers
Replacing myself with tkent who is specifically interested in DOM API conformance.
5 years, 6 months ago (2015-06-23 21:12:47 UTC) #11
tkent
lgtm
5 years, 6 months ago (2015-06-23 23:35:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198393002/20001
5 years, 6 months ago (2015-06-23 23:36:46 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 00:40:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197687

Powered by Google App Engine
This is Rietveld 408576698